From: Jan Kara <jack@suse.cz>
To: Matthew Wilcox <willy@infradead.org>
Cc: August Wikerfors <august.wikerfors@gmail.com>,
Mohan R <mohan43u@gmail.com>,
uwe.sauter.de@gmail.com,
almaz.alexandrovich@paragon-software.com,
linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev,
Jan Kara <jack@suse.cz>
Subject: Re: Bug using new ntfs3 file system driver (5.15.2 on Arch Linux)
Date: Mon, 3 Jan 2022 16:20:23 +0100 [thread overview]
Message-ID: <20220103152023.evkgkitqkxsgsn2m@quack3> (raw)
In-Reply-To: <Ycu2MGt/raXJ+wCb@casper.infradead.org>
On Wed 29-12-21 01:13:20, Matthew Wilcox wrote:
> On Tue, Dec 28, 2021 at 10:00:53PM +0100, August Wikerfors wrote:
> > (resending from gmail due to bounce with outlook)
> >
> > Hi, I ran into a bug with a very similar call trace, also when copying files
> > with rsync from a filesystem mounted using ntfs3. I was able to reproduce it
> > on both the default Arch Linux kernel (5.15.11-arch2-1) and on mainline
> > 5.16-rc7.
>
> Hi August! This is very helpful; thank you for putting in the work to
> figure this out. I am still a little baffled:
>
> > [ 486.361177] RIP: 0010:0xffffff8306d925ff
> > [ 486.361192] Code: Unable to access opcode bytes at RIP 0xffffff8306d925d5.
> > [ 486.361214] RSP: 0018:ffffaa9ec0f8fb37 EFLAGS: 00010246
> > [ 486.361232] RAX: 0000000000000000 RBX: 00000000000002ab RCX: 0000000000000000
> > [ 486.361255] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
> > [ 486.361279] RBP: ffaa9ec0f8fbf800 R08: 0000000000000000 R09: 0000000000000000
> > [ 486.361302] R10: 0000000000000000 R11: 0000000000000000 R12: ff99687f5746e000
> > [ 486.361324] R13: 00000001112ccaff R14: fffcbb8097368000 R15: 00000000000001ff
> > [ 486.361349] ? page_cache_ra_unbounded+0x1c5/0x250
> > [ 486.361369] ? filemap_get_pages+0x117/0x730
> > [ 486.361386] ? make_kuid+0xf/0x20
> > [ 486.361401] ? generic_permission+0x27/0x210
> > [ 486.361419] ? walk_component+0x11d/0x1c0
> > [ 486.361435] ? filemap_read+0xb9/0x360
> > [ 486.361451] ? new_sync_read+0x159/0x1f0
> > [ 486.361467] ? vfs_read+0xff/0x1a0
> > [ 486.361489] ? ksys_read+0x67/0xf0
> > [ 486.361503] ? do_syscall_64+0x5c/0x90
> >
> > $ scripts/faddr2line vmlinux.5.15.11-arch2-1 page_cache_ra_unbounded+0x1c5/0x250
> > page_cache_ra_unbounded+0x1c5/0x250:
> > filemap_invalidate_unlock_shared at include/linux/fs.h:853
> > (inlined by) page_cache_ra_unbounded at mm/readahead.c:240
>
> So ... Jan added this code in commit 730633f0b7f9, but I don't see how
> it could be buggy:
I don't think the problem is with my code. The address
page_cache_ra_unbounded+0x1c5/0x250 is from the stack which means it is a
return address for the function that's currently executing or just to be
called - presumably from read_pages(). And note that we crashed because we
tried to call / jump to invalid address. So most likely aops->readpage(),
aops->readahead(), or aops->readpages() was the bogus address
0xffffff8306d925d5. How it got there I don't know but I'd closely look into
the ntfs3 driver...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-01-06 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 14:13 Bug using new ntfs3 file system driver (5.15.2 on Arch Linux) Mohan R
2021-11-27 14:50 ` Matthew Wilcox
2021-12-28 20:45 ` August Wikerfors
2021-12-28 21:00 ` August Wikerfors
2021-12-29 1:13 ` Matthew Wilcox
2022-01-03 15:20 ` Jan Kara [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-19 7:48 Uwe Sauter
2021-11-19 13:13 ` Matthew Wilcox
2021-11-19 14:19 ` Uwe Sauter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103152023.evkgkitqkxsgsn2m@quack3 \
--to=jack@suse.cz \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=august.wikerfors@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mohan43u@gmail.com \
--cc=ntfs3@lists.linux.dev \
--cc=uwe.sauter.de@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox