From: Liangbin Lian <jjm2473@gmail.com>
To: ntfs3@lists.linux.dev, almaz.alexandrovich@paragon-software.com
Cc: linux-kernel@vger.kernel.org, Liangbin Lian <jjm2473@gmail.com>
Subject: [PATCH] fs/ntfs3: fix null pointer dereference in d_flags_for_inode
Date: Fri, 6 May 2022 11:46:56 +0800 [thread overview]
Message-ID: <20220506034656.50038-1-jjm2473@gmail.com> (raw)
ntfs_read_mft may return inode with null i_op, cause null pointer dereference in d_flags_for_inode (inode->i_op->get_link).
Reproduce:
- sudo mount -t ntfs3 -o loop ntfs.img ntfs
- ls ntfs/'$Extend/$Quota'
The call trace is shown below (striped):
BUG: kernel NULL pointer dereference, address: 0000000000000008
CPU: 0 PID: 577 Comm: ls Tainted: G OE 5.16.0-0.bpo.4-amd64 #1 Debian 5.16.12-1~bpo11+1
RIP: 0010:d_flags_for_inode+0x65/0x90
Call Trace:
ntfs_lookup
+--- dir_search_u
| +--- ntfs_iget5
| +--- ntfs_read_mft
+--- d_splice_alias
+--- __d_add
+--- d_flags_for_inode
Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
---
fs/ntfs3/inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
index 9eab11e3b..b68d26fa8 100644
--- a/fs/ntfs3/inode.c
+++ b/fs/ntfs3/inode.c
@@ -45,7 +45,6 @@ static struct inode *ntfs_read_mft(struct inode *inode,
struct MFT_REC *rec;
struct runs_tree *run;
- inode->i_op = NULL;
/* Setup 'uid' and 'gid' */
inode->i_uid = sbi->options->fs_uid;
inode->i_gid = sbi->options->fs_gid;
--
2.32.0 (Apple Git-132)
next reply other threads:[~2022-05-06 3:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 3:46 Liangbin Lian [this message]
2022-05-26 10:22 ` [PATCH] fs/ntfs3: fix null pointer dereference in d_flags_for_inode Almaz Alexandrovich
2022-05-28 13:42 ` 练亮斌
2022-05-31 16:34 ` Konstantin Komarov
2022-06-11 2:56 ` 练亮斌
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506034656.50038-1-jjm2473@gmail.com \
--to=jjm2473@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox