Re: [PATCH 07/13] xfs: document the invalidate_bdev call in invalidate_bdev

Christoph Hellwig
2023-08-10T15:53:54Z

On Wed, Aug 09, 2023 at 03:39:23PM -0700, Darrick J. Wong wrote:
> > + * read from the same page in the pagecache.
> > + *
> > + * The unmount writes updated inode metadata to disk directly. The XFS
> > + * buffer cache does not use the bdev pagecache, nor does it invalidate
> > + * the pagecache on umount. If the above scenario occurs, the pagecache
>
> This sentence reads a little strangely, since "nor does it invalidate"
> would seem to conflict with the invalidate_bdev call below. I suggest
> changing the verb a bit:
>
> "The XFS buffer cache does not use the bdev pagecache, so it needs to
> invalidate that pagecache on unmount."

Agreed. I'll forward it to the original author of the sentence time
permitting :)