From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B285715DBBA; Mon, 14 Oct 2024 03:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728878307; cv=none; b=PPqm3Ka+v7aYZEWz3zylQHVY6bgTn+G52PL/cSUbb5LTkH6MZAtGnEizeNOkjVQutY3nJsl0qPCs6dfOHwhmC+QlpZrapYMVUGtqgS26XYAx/EFYHyq/b7XPXXCkLnS4eBr/wlPbcztUT5K4K3iIcU5+zEUr+C4PcH2yplgRhIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728878307; c=relaxed/simple; bh=L4qs588DXO3P5ZVLVZ4eJJ6AhKwVt9Z6CGGMiqvOrgA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ctwd2NkQ6586f4sA2+BaXtZRyNWJlDluncMJe4sqzS+KQloLhVZ7BoSUrItt+QA7pbSe0/rWHEybRb2YO666zXlMRs3hQD71JkWmbZRdfSaL5pXkLctPy9vBJ7BY1H9YdLeYPp/h/WBB5hcbFtwZLT27+iA1oMPOVpuqs+mkLuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EnCsy1NF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EnCsy1NF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB017C4CEC3; Mon, 14 Oct 2024 03:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728878307; bh=L4qs588DXO3P5ZVLVZ4eJJ6AhKwVt9Z6CGGMiqvOrgA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EnCsy1NFN0VAG165bp+WGsBvEzKHqIciJWtWjc+oRvZIrDAI2/w+Yfg100zrcYEDm B+g87wwYiwu8iMTm43qPstraezD82SmvYtLsudg8wXyLAL5kXt/4Kmt8J2hNkEdC3Q Mq3rOfWLLAY5XVRhaxg09qsdwPYP9JhA6TuLvQzljIhLx1oM13cAf6+UendsxgCSeM Y2Ysnn1uQECYswwBYGk2ufFDkKpjaxELA+I2EoTZgJohZvMiammCWz1kd4Ahv5FXzn yVSkylBeWux12XQiq0IcPMtmxXrlltsiN1rleMk1d6OrtiQo0yC7M2Ug/JbL5voHi2 3Xpg8K5ptR0QQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Konstantin Komarov , syzbot+8c652f14a0fde76ff11d@syzkaller.appspotmail.com, Sasha Levin , ntfs3@lists.linux.dev Subject: [PATCH AUTOSEL 6.6 09/17] fs/ntfs3: Additional check in ntfs_file_release Date: Sun, 13 Oct 2024 23:57:59 -0400 Message-ID: <20241014035815.2247153-9-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241014035815.2247153-1-sashal@kernel.org> References: <20241014035815.2247153-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.56 Content-Transfer-Encoding: 8bit From: Konstantin Komarov [ Upstream commit 031d6f608290c847ba6378322d0986d08d1a645a ] Reported-by: syzbot+8c652f14a0fde76ff11d@syzkaller.appspotmail.com Signed-off-by: Konstantin Komarov Signed-off-by: Sasha Levin --- fs/ntfs3/file.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c index cd69cbd0aaae7..d05c433a55f35 100644 --- a/fs/ntfs3/file.c +++ b/fs/ntfs3/file.c @@ -1171,7 +1171,14 @@ static int ntfs_file_release(struct inode *inode, struct file *file) /* If we are last writer on the inode, drop the block reservation. */ if (sbi->options->prealloc && ((file->f_mode & FMODE_WRITE) && - atomic_read(&inode->i_writecount) == 1)) { + atomic_read(&inode->i_writecount) == 1) + /* + * The only file when inode->i_fop = &ntfs_file_operations and + * init_rwsem(&ni->file.run_lock) is not called explicitly is MFT. + * + * Add additional check here. + */ + && inode->i_ino != MFT_REC_MFT) { ni_lock(ni); down_write(&ni->file.run_lock); -- 2.43.0