From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2513525F7A1; Mon, 7 Apr 2025 18:13:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049621; cv=none; b=m3fE4YDmUZEOdriT7DS9/6RSakP7+BjFihIWru/SsIuq5A+F5FkvUHoOi424lSJDYJfUGOSzkgsXBDjFu5Lk/hLlSjH3BEO5s28RrN3ESEAKEYmHfI5a1ggquzHBtMFf0ZpHXECM7Rnq9uEsLcWT3LPq/5DtUlPirwt9E3jRJus= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049621; c=relaxed/simple; bh=elxLAKKp8j6ZCIT0dvsNLUQT3EdRnCS04EG7mh6WIfc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=i7TU91RrdBStBNJxDuspqo+t7/E3Ht5xTAjTYl81HZIw4wwI3QfPpdShpJ2svWbmXEGORn+oWvQma3KEbupmc7E706ecjoc51o7R/qpiDrIn+jSn9O0ckEPcST7xqb/NKRKmNbHhe5FMWWa/c0hMTqgqLgqt4rVGISWWwHA6UZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uyJeMUan; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uyJeMUan" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33911C4CEE9; Mon, 7 Apr 2025 18:13:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744049621; bh=elxLAKKp8j6ZCIT0dvsNLUQT3EdRnCS04EG7mh6WIfc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uyJeMUanZ4ltiZugiuwtPgdpM62JXTf3rPspM/5ZxZuBecMsBKEYsfiYifqPttP+y NUIEVXo4kZOfK0DAo8h1AJeJDxRL6LxyNRu+ME7NhIwrVIzMmjI44DYXe5U+W5NwGu mvTStl134ogXa5SzSBqzTAEo2lO1mU9+4IGxALLu2Bx8mOLmn7qSTmvXI/akQp/EtE b4ENUW6VtUd/9MVoLe4LBKp1Z9lsrCO3B5+6Bm0YtqER8OP9E1IGYNNbnHb4jpxSxl ST2V73b9DrVTzt+mr9vDc1GAHv1H8vjEjUPVTnsbiGfdzIfrLjDvWKMup7DBqXmqgY 0nWCcwk5oH+Vg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Edward Adam Davis , syzbot+e37dd1dfc814b10caa55@syzkaller.appspotmail.com, Konstantin Komarov , Sasha Levin , ntfs3@lists.linux.dev Subject: [PATCH AUTOSEL 6.12 03/22] fs/ntfs3: Fix WARNING in ntfs_extend_initialized_size Date: Mon, 7 Apr 2025 14:13:13 -0400 Message-Id: <20250407181333.3182622-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250407181333.3182622-1-sashal@kernel.org> References: <20250407181333.3182622-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.12.22 Content-Transfer-Encoding: 8bit From: Edward Adam Davis [ Upstream commit ff355926445897cc9fdea3b00611e514232c213c ] Syzbot reported a WARNING in ntfs_extend_initialized_size. The data type of in->i_valid and to is u64 in ntfs_file_mmap(). If their values are greater than LLONG_MAX, overflow will occur because the data types of the parameters valid and new_valid corresponding to the function ntfs_extend_initialized_size() are loff_t. Before calling ntfs_extend_initialized_size() in the ntfs_file_mmap(), the "ni->i_valid < to" has been determined, so the same WARN_ON determination is not required in ntfs_extend_initialized_size(). Just execute the ntfs_extend_initialized_size() in ntfs_extend() to make a WARN_ON check. Reported-and-tested-by: syzbot+e37dd1dfc814b10caa55@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=e37dd1dfc814b10caa55 Signed-off-by: Edward Adam Davis Signed-off-by: Konstantin Komarov Signed-off-by: Sasha Levin --- fs/ntfs3/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c index d537b1506dca5..bf685392996d1 100644 --- a/fs/ntfs3/file.c +++ b/fs/ntfs3/file.c @@ -410,6 +410,7 @@ static int ntfs_extend(struct inode *inode, loff_t pos, size_t count, } if (extend_init && !is_compressed(ni)) { + WARN_ON(ni->i_valid >= pos); err = ntfs_extend_initialized_size(file, ni, ni->i_valid, pos); if (err) goto out; -- 2.39.5