From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B22DD267B1F; Mon, 7 Apr 2025 18:14:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049695; cv=none; b=fyQ9b6eB4LWEbeiLZJX60CORnikVaIjs9zjHOjLvfYGxVLDOeH7KB7Zox+ryUbxnKnMerVsCdIB0RRU+bfyIuXcIy2PMQ2/dcc9fKV7nkCoQgyim1eNm/hAUAofdhqxSMLWpyFUuB4lSA7yhkFw0RABZODncVtMMiee+FeDgRUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049695; c=relaxed/simple; bh=nXY8em9monBQsY1lfRU5oYpVAbgufBykXkdRAmedgp0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hzEanhX15aDX8h6SacWSyA/yy4FPXQYksh6Un/Q9V375ip+4aBiDSs5v6voC2adjMZuIVhnv9qPrfVVgD5y+o6vU8wzM96NgrBnkVPtISD+MTnKdaCMjT7sY4jtQbfewEhLgcyBcp9Upx10v3bVj95HK0vepaJyT0iVJOybwD6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TLmBwDfa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TLmBwDfa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AE54C4CEE9; Mon, 7 Apr 2025 18:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744049695; bh=nXY8em9monBQsY1lfRU5oYpVAbgufBykXkdRAmedgp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TLmBwDfa8fMiR1CMn3x76cU3JGHulzjaNOG85lrBOjcAIYPpNnU3i8glKqq8Oyh7W G5rWna7f6Rphn32DsNcQr0nAId93c0l8l3BTqAaJeTUyhBCN8VPdlxqkgtTiCOd/y/ PFf5lwBWD/SkIU4IaCFBj2AjpWHShvnb6mNmK3AEkkhYKLGV4rg5SGEdOZ7ts2i4uY 8eBEurN07j5EHhLS6DX2y2O6joP8P83aQSnmH1p1ad/6lU0//3mzZ7PxbCal2OGcMe rECVaeBfQQ2tGRakbnV1jjA5JTINGIVThqJzrvhMtonJ3IT7BBlejZxnBfc8OUHFu/ LvuSkyf//ZtAQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Edward Adam Davis , syzbot+e37dd1dfc814b10caa55@syzkaller.appspotmail.com, Konstantin Komarov , Sasha Levin , ntfs3@lists.linux.dev Subject: [PATCH AUTOSEL 6.1 02/13] fs/ntfs3: Fix WARNING in ntfs_extend_initialized_size Date: Mon, 7 Apr 2025 14:14:36 -0400 Message-Id: <20250407181449.3183687-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250407181449.3183687-1-sashal@kernel.org> References: <20250407181449.3183687-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.133 Content-Transfer-Encoding: 8bit From: Edward Adam Davis [ Upstream commit ff355926445897cc9fdea3b00611e514232c213c ] Syzbot reported a WARNING in ntfs_extend_initialized_size. The data type of in->i_valid and to is u64 in ntfs_file_mmap(). If their values are greater than LLONG_MAX, overflow will occur because the data types of the parameters valid and new_valid corresponding to the function ntfs_extend_initialized_size() are loff_t. Before calling ntfs_extend_initialized_size() in the ntfs_file_mmap(), the "ni->i_valid < to" has been determined, so the same WARN_ON determination is not required in ntfs_extend_initialized_size(). Just execute the ntfs_extend_initialized_size() in ntfs_extend() to make a WARN_ON check. Reported-and-tested-by: syzbot+e37dd1dfc814b10caa55@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=e37dd1dfc814b10caa55 Signed-off-by: Edward Adam Davis Signed-off-by: Konstantin Komarov Signed-off-by: Sasha Levin --- fs/ntfs3/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c index 72e25842f5dc9..46eec986ec9ca 100644 --- a/fs/ntfs3/file.c +++ b/fs/ntfs3/file.c @@ -354,6 +354,7 @@ static int ntfs_extend(struct inode *inode, loff_t pos, size_t count, } if (extend_init && !is_compressed(ni)) { + WARN_ON(ni->i_valid >= pos); err = ntfs_extend_initialized_size(file, ni, ni->i_valid, pos); if (err) goto out; -- 2.39.5