From: kernel test robot <lkp@intel.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
ntfs3@lists.linux.dev
Subject: [paragon-software-group-ntfs3:devel 23/23] fs/ntfs3/super.c:388:3: warning: unannotated fall-through between switch labels
Date: Wed, 04 Feb 2026 14:27:11 +0800 [thread overview]
Message-ID: <202602041402.uojBz5QY-lkp@intel.com> (raw)
tree: https://github.com/Paragon-Software-Group/linux-ntfs3.git devel
head: 3c6248937fb9fe5cfb29aa8813e18c50095e4db7
commit: 3c6248937fb9fe5cfb29aa8813e18c50095e4db7 [23/23] fs/ntfs3: allow explicit boolean acl/prealloc mount options
config: s390-randconfig-001-20260204 (https://download.01.org/0day-ci/archive/20260204/202602041402.uojBz5QY-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260204/202602041402.uojBz5QY-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602041402.uojBz5QY-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/ntfs3/super.c:388:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
388 | case Opt_acl:
| ^
fs/ntfs3/super.c:388:3: note: insert '__attribute__((fallthrough));' to silence this warning
388 | case Opt_acl:
| ^
| __attribute__((fallthrough));
fs/ntfs3/super.c:388:3: note: insert 'break;' to avoid fall-through
388 | case Opt_acl:
| ^
| break;
1 warning generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for CAN_DEV
Depends on [n]: NETDEVICES [=n] && CAN [=m]
Selected by [m]:
- CAN [=m] && NET [=y]
WARNING: unmet direct dependencies detected for OF_GPIO
Depends on [n]: GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n]
Selected by [y]:
- REGULATOR_RT5133 [=y] && REGULATOR [=y] && I2C [=y] && GPIOLIB [=y] && OF [=y]
vim +388 fs/ntfs3/super.c
610f8f5a7baf998 Kari Argillander 2021-09-07 323
610f8f5a7baf998 Kari Argillander 2021-09-07 324 static int ntfs_fs_parse_param(struct fs_context *fc,
610f8f5a7baf998 Kari Argillander 2021-09-07 325 struct fs_parameter *param)
610f8f5a7baf998 Kari Argillander 2021-09-07 326 {
610f8f5a7baf998 Kari Argillander 2021-09-07 327 struct ntfs_mount_options *opts = fc->fs_private;
610f8f5a7baf998 Kari Argillander 2021-09-07 328 struct fs_parse_result result;
610f8f5a7baf998 Kari Argillander 2021-09-07 329 int opt;
610f8f5a7baf998 Kari Argillander 2021-09-07 330
610f8f5a7baf998 Kari Argillander 2021-09-07 331 opt = fs_parse(fc, ntfs_fs_parameters, param, &result);
610f8f5a7baf998 Kari Argillander 2021-09-07 332 if (opt < 0)
610f8f5a7baf998 Kari Argillander 2021-09-07 333 return opt;
610f8f5a7baf998 Kari Argillander 2021-09-07 334
610f8f5a7baf998 Kari Argillander 2021-09-07 335 switch (opt) {
82cae269cfa9530 Konstantin Komarov 2021-08-13 336 case Opt_uid:
c449cb5d1bcedb8 Eric Sandeen 2024-06-27 337 opts->fs_uid = result.uid;
82cae269cfa9530 Konstantin Komarov 2021-08-13 338 break;
82cae269cfa9530 Konstantin Komarov 2021-08-13 339 case Opt_gid:
c449cb5d1bcedb8 Eric Sandeen 2024-06-27 340 opts->fs_gid = result.gid;
82cae269cfa9530 Konstantin Komarov 2021-08-13 341 break;
82cae269cfa9530 Konstantin Komarov 2021-08-13 342 case Opt_umask:
610f8f5a7baf998 Kari Argillander 2021-09-07 343 if (result.uint_32 & ~07777)
610f8f5a7baf998 Kari Argillander 2021-09-07 344 return invalf(fc, "ntfs3: Invalid value for umask.");
610f8f5a7baf998 Kari Argillander 2021-09-07 345 opts->fs_fmask_inv = ~result.uint_32;
610f8f5a7baf998 Kari Argillander 2021-09-07 346 opts->fs_dmask_inv = ~result.uint_32;
610f8f5a7baf998 Kari Argillander 2021-09-07 347 opts->fmask = 1;
610f8f5a7baf998 Kari Argillander 2021-09-07 348 opts->dmask = 1;
82cae269cfa9530 Konstantin Komarov 2021-08-13 349 break;
82cae269cfa9530 Konstantin Komarov 2021-08-13 350 case Opt_dmask:
610f8f5a7baf998 Kari Argillander 2021-09-07 351 if (result.uint_32 & ~07777)
610f8f5a7baf998 Kari Argillander 2021-09-07 352 return invalf(fc, "ntfs3: Invalid value for dmask.");
610f8f5a7baf998 Kari Argillander 2021-09-07 353 opts->fs_dmask_inv = ~result.uint_32;
82cae269cfa9530 Konstantin Komarov 2021-08-13 354 opts->dmask = 1;
82cae269cfa9530 Konstantin Komarov 2021-08-13 355 break;
82cae269cfa9530 Konstantin Komarov 2021-08-13 356 case Opt_fmask:
610f8f5a7baf998 Kari Argillander 2021-09-07 357 if (result.uint_32 & ~07777)
610f8f5a7baf998 Kari Argillander 2021-09-07 358 return invalf(fc, "ntfs3: Invalid value for fmask.");
610f8f5a7baf998 Kari Argillander 2021-09-07 359 opts->fs_fmask_inv = ~result.uint_32;
82cae269cfa9530 Konstantin Komarov 2021-08-13 360 opts->fmask = 1;
82cae269cfa9530 Konstantin Komarov 2021-08-13 361 break;
610f8f5a7baf998 Kari Argillander 2021-09-07 362 case Opt_immutable:
568f1140b9ca92d Konstantin Komarov 2024-07-01 363 opts->sys_immutable = 1;
610f8f5a7baf998 Kari Argillander 2021-09-07 364 break;
82cae269cfa9530 Konstantin Komarov 2021-08-13 365 case Opt_discard:
568f1140b9ca92d Konstantin Komarov 2024-07-01 366 opts->discard = 1;
82cae269cfa9530 Konstantin Komarov 2021-08-13 367 break;
82cae269cfa9530 Konstantin Komarov 2021-08-13 368 case Opt_force:
568f1140b9ca92d Konstantin Komarov 2024-07-01 369 opts->force = 1;
82cae269cfa9530 Konstantin Komarov 2021-08-13 370 break;
82cae269cfa9530 Konstantin Komarov 2021-08-13 371 case Opt_sparse:
568f1140b9ca92d Konstantin Komarov 2024-07-01 372 opts->sparse = 1;
82cae269cfa9530 Konstantin Komarov 2021-08-13 373 break;
82cae269cfa9530 Konstantin Komarov 2021-08-13 374 case Opt_nohidden:
568f1140b9ca92d Konstantin Komarov 2024-07-01 375 opts->nohidden = 1;
82cae269cfa9530 Konstantin Komarov 2021-08-13 376 break;
098250db5dfcc01 Konstantin Komarov 2022-09-12 377 case Opt_hide_dot_files:
568f1140b9ca92d Konstantin Komarov 2024-07-01 378 opts->hide_dot_files = 1;
098250db5dfcc01 Konstantin Komarov 2022-09-12 379 break;
1d07a9dfa19914a Daniel Pinto 2022-10-10 380 case Opt_windows_names:
568f1140b9ca92d Konstantin Komarov 2024-07-01 381 opts->windows_names = 1;
1d07a9dfa19914a Daniel Pinto 2022-10-10 382 break;
16b3dbfb5d5cdfb Konstantin Komarov 2023-02-15 383 case Opt_showmeta:
568f1140b9ca92d Konstantin Komarov 2024-07-01 384 opts->showmeta = 1;
16b3dbfb5d5cdfb Konstantin Komarov 2023-02-15 385 break;
3c6248937fb9fe5 Konstantin Komarov 2026-01-30 386 case Opt_acl_bool:
3c6248937fb9fe5 Konstantin Komarov 2026-01-30 387 if (result.boolean) {
82cae269cfa9530 Konstantin Komarov 2021-08-13 @388 case Opt_acl:
82cae269cfa9530 Konstantin Komarov 2021-08-13 389 #ifdef CONFIG_NTFS3_FS_POSIX_ACL
610f8f5a7baf998 Kari Argillander 2021-09-07 390 fc->sb_flags |= SB_POSIXACL;
82cae269cfa9530 Konstantin Komarov 2021-08-13 391 #else
96de65a9413e042 Konstantin Komarov 2023-01-17 392 return invalf(
96de65a9413e042 Konstantin Komarov 2023-01-17 393 fc, "ntfs3: Support for ACL not compiled in!");
82cae269cfa9530 Konstantin Komarov 2021-08-13 394 #endif
3c6248937fb9fe5 Konstantin Komarov 2026-01-30 395 } else
610f8f5a7baf998 Kari Argillander 2021-09-07 396 fc->sb_flags &= ~SB_POSIXACL;
610f8f5a7baf998 Kari Argillander 2021-09-07 397 break;
e274cde8c7550ca Kari Argillander 2021-09-07 398 case Opt_iocharset:
610f8f5a7baf998 Kari Argillander 2021-09-07 399 kfree(opts->nls_name);
610f8f5a7baf998 Kari Argillander 2021-09-07 400 opts->nls_name = param->string;
610f8f5a7baf998 Kari Argillander 2021-09-07 401 param->string = NULL;
82cae269cfa9530 Konstantin Komarov 2021-08-13 402 break;
82cae269cfa9530 Konstantin Komarov 2021-08-13 403 case Opt_prealloc:
3c6248937fb9fe5 Konstantin Komarov 2026-01-30 404 opts->prealloc = 1;
3c6248937fb9fe5 Konstantin Komarov 2026-01-30 405 break;
3c6248937fb9fe5 Konstantin Komarov 2026-01-30 406 case Opt_prealloc_bool:
3c6248937fb9fe5 Konstantin Komarov 2026-01-30 407 opts->prealloc = result.boolean;
82cae269cfa9530 Konstantin Komarov 2021-08-13 408 break;
a3a956c78efaa20 Konstantin Komarov 2022-09-23 409 case Opt_nocase:
568f1140b9ca92d Konstantin Komarov 2024-07-01 410 opts->nocase = 1;
a3a956c78efaa20 Konstantin Komarov 2022-09-23 411 break;
82cae269cfa9530 Konstantin Komarov 2021-08-13 412 default:
610f8f5a7baf998 Kari Argillander 2021-09-07 413 /* Should not be here unless we forget add case. */
82cae269cfa9530 Konstantin Komarov 2021-08-13 414 return -EINVAL;
82cae269cfa9530 Konstantin Komarov 2021-08-13 415 }
82cae269cfa9530 Konstantin Komarov 2021-08-13 416 return 0;
82cae269cfa9530 Konstantin Komarov 2021-08-13 417 }
82cae269cfa9530 Konstantin Komarov 2021-08-13 418
:::::: The code at line 388 was first introduced by commit
:::::: 82cae269cfa953032fbb8980a7d554d60fb00b17 fs/ntfs3: Add initialization of super block
:::::: TO: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
:::::: CC: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-02-04 6:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202602041402.uojBz5QY-lkp@intel.com \
--to=lkp@intel.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=llvm@lists.linux.dev \
--cc=ntfs3@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox