From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBB5AEA0 for ; Fri, 2 Sep 2022 01:32:57 +0000 (UTC) Received: from canpemm500005.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MJgNT71ClzHncr; Fri, 2 Sep 2022 09:31:05 +0800 (CST) Received: from [10.174.178.134] (10.174.178.134) by canpemm500005.china.huawei.com (7.192.104.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 2 Sep 2022 09:32:54 +0800 Subject: Re: [PATCH v2 13/14] ext2: replace bh_submit_read() helper with bh_read_locked() To: Al Viro CC: , , , , , , , , , , , , , , , , , , References: <20220901133505.2510834-1-yi.zhang@huawei.com> <20220901133505.2510834-14-yi.zhang@huawei.com> From: Zhang Yi Message-ID: <3fdab5fd-1efa-9668-da5c-889e9bfa1524@huawei.com> Date: Fri, 2 Sep 2022 09:32:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.134] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500005.china.huawei.com (7.192.104.229) X-CFilter-Loop: Reflected On 2022/9/2 8:30, Al Viro wrote: > On Thu, Sep 01, 2022 at 09:35:04PM +0800, Zhang Yi wrote: >> bh_submit_read() and the uptodate check logic in bh_uptodate_or_lock() >> has been integrated in bh_read() helper, so switch to use it directly. > > s/bh_read_locked/bh_read/ in the summary? > Sorry, I don't get your question, I have already replace bh_read_locked() with bh_read() in the commit message, there is no bh_read_locked in the whole patch. Am I missing something? Thanks, Yi.