From: Joe Perches <joe@perches.com>
To: Kari Argillander <kari.argillander@gmail.com>, apw@canonical.com
Cc: dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
linux-kernel@vger.kernel.org, ntfs3@lists.linux.dev
Subject: Re: [PATCH] checkpatch: Remove cvs keyword check
Date: Tue, 26 Oct 2021 17:26:21 -0700 [thread overview]
Message-ID: <868c29d45172a151b6a751de4ba32165cbf7a4cc.camel@perches.com> (raw)
In-Reply-To: <20211026231637.3750-1-kari.argillander@gmail.com>
On Wed, 2021-10-27 at 02:16 +0300, Kari Argillander wrote:
> Time has pass and we do not need these anymore as almost all people are
> using git now days. Those who use cvs for kernel development probably
> will handle cvs pretty well already so this check is not needed anymore.
I think it's a relatively harmless thing to keep.
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4017,12 +4017,6 @@ sub process {
> }
> }
>
> -# check for RCS/CVS revision markers
> - if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
Looks like this would be better using
if ($rawline =~ /^\+.*\b\$(?:Revision|Log|Id)\$?\b/) {
> - WARN("CVS_KEYWORD",
> - "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
next prev parent reply other threads:[~2021-10-27 0:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 23:16 [PATCH] checkpatch: Remove cvs keyword check Kari Argillander
2021-10-27 0:26 ` Joe Perches [this message]
2021-10-27 7:35 ` Kari Argillander
2021-10-27 9:21 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868c29d45172a151b6a751de4ba32165cbf7a4cc.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=kari.argillander@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox