From: Matthew Wilcox <willy@infradead.org>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: ntfs3@lists.linux.dev
Subject: Re: [PATCH] ntfs3: Remove an access to page->index
Date: Mon, 16 Dec 2024 15:24:17 +0000 [thread overview]
Message-ID: <Z2BGIdCHXPLpgruv@casper.infradead.org> (raw)
In-Reply-To: <20241128194430.724278-1-willy@infradead.org>
On Thu, Nov 28, 2024 at 07:44:28PM +0000, Matthew Wilcox (Oracle) wrote:
> Convert the first page passed to ni_write_frame() to a folio and use
> folio_pos() on that instead of open-coding the access to folio->index,
> cast & shift.
Ping? It's been two weeks, and this is not in linux-next 20241216
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> fs/ntfs3/frecord.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
> index 8b39d0ce5f28..c57f0686b14b 100644
> --- a/fs/ntfs3/frecord.c
> +++ b/fs/ntfs3/frecord.c
> @@ -2726,9 +2726,10 @@ int ni_write_frame(struct ntfs_inode *ni, struct page **pages,
> {
> int err;
> struct ntfs_sb_info *sbi = ni->mi.sbi;
> + struct folio *folio = page_folio(pages[0]);
> u8 frame_bits = NTFS_LZNT_CUNIT + sbi->cluster_bits;
> u32 frame_size = sbi->cluster_size << NTFS_LZNT_CUNIT;
> - u64 frame_vbo = (u64)pages[0]->index << PAGE_SHIFT;
> + u64 frame_vbo = folio_pos(folio);
> CLST frame = frame_vbo >> frame_bits;
> char *frame_ondisk = NULL;
> struct page **pages_disk = NULL;
> --
> 2.45.2
>
prev parent reply other threads:[~2024-12-16 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 19:44 [PATCH] ntfs3: Remove an access to page->index Matthew Wilcox (Oracle)
2024-12-16 15:24 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2BGIdCHXPLpgruv@casper.infradead.org \
--to=willy@infradead.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox