From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F40AF6EF11 for ; Wed, 28 Feb 2024 16:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709137958; cv=none; b=N8oemKoKx52ljlYN5RgC6txxi43GQ9lXgaIGL0p9cXkWN45Mzk+qHEB5Bv3uDpAmcEAy7JCTU6hDVzMtr0IiJ11t/LoZTF1JSczmH/iTT0Q+Aw4TLkl95l7TMH4U8p3ugF7DyxSMkFQWOStt+bg+AcQw7lktip/Yc975+ZXoQdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709137958; c=relaxed/simple; bh=d3rBt9ZoE8GZdyPyKzBUGndsZ5i3T4Yv6JMjZVtygx0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=upTXDqhW4W2qoTDe7bu1VO0ZbvudCHVF97hJSzyWaRgEZb1/j0DbPjbAb2Iv9/6PbAujYODXH3lpyxYC66h6PjpMVmQ8/NxV5mUz9wf+6JaZq+3gz54iND4+cQLHMqEsFUSASy4LVQa0bsvS2vxrOIucGDmLomZiK3CBWuOiTag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=etKJvN+W; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="etKJvN+W" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-608e0b87594so42346197b3.1 for ; Wed, 28 Feb 2024 08:32:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709137956; x=1709742756; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QhE1MQsKvhB9REC+482u9v2wKLir8r1v7/0zkgMeFU8=; b=etKJvN+WehOcmF2gbPLdSNQ1x0uQ/lGWpIgMhJVnT9qsRBRo3H7MMonaBel2gD3iCY xJ6aBsHtVpUno19uPG+MvNOp5KnUyXyZ1iJd48mnD0GPLwdZpGhY8qqW2JiyoYJpSBRy +UQZcgfNWN2ruH/WCz0Jsv91/te69wK5iEJUAewavKoHCO+qUsiTOhPa6cngPqDRHtHx N87BHDClFh5ze2pIBjvMkYOOGxWkBFKoBSujy3+FTVk3JVP+whI8lo7/rDLiyWtc4Cc5 EZGm1VU5sVvn1e0b1Zan9i3wB6Sm5x5sHxUVYR1XFvoncaGLmgs4pgBJBnjrszOEdxLX HXag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709137956; x=1709742756; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QhE1MQsKvhB9REC+482u9v2wKLir8r1v7/0zkgMeFU8=; b=AGfdnuLAdsa/yx6e4DTfEuiPINjGuabq7P0nEU+TzvNaP/J16MUv803xxyqHBLKgjM b4/Wc8ceen9/s7XRyfUEKO2u+YZD57N8tM2fKFVKrGetYmsfgv+ZfaTQwkfAsa5vWa/a uoiZNEECmaTk9ES3nr06DfmteDXsJa/EX8x1wdHSqFaDY8/fjiqjCNncagxabN8CB+CX PMfsbbQQIoLmWsXmgTlcAXOXtF1lmBbWGQwhs5Juo8+MStnaLscjME5Onfw4QjIxuxm3 esM1yYQ21gU93Xxse6erGC4dKT5M2YwaL8vNOxKbXv2Ja5DUbt1MrHoWHa+aEJr3TqkN daKg== X-Forwarded-Encrypted: i=1; AJvYcCXM6C/YGrFNPyy/jHSRUkeVhd9cH+Leq2xKkozw2Zd2vGWWLIDVBKsvNFtvN70ZmPmjPiBONYrzzrZexO4JN/1VeYsw4Xg= X-Gm-Message-State: AOJu0YwYUvmGBskaU3cNuVegC7hKeNXdGe9QqyRssth8AScGrwWSlYHA Ujj4JsC6JaQ58xE2VkS7KSfYE0+QhgQd5JeDTu6aY4mxxXDbTz7W X-Google-Smtp-Source: AGHT+IF7y727lGvQC58bwkZEZGqk/V3taxdRWZKAkhTKPUp2zVZ/V5NrHMWuRoL1mydS8eaxnJgy/g== X-Received: by 2002:a81:9a43:0:b0:607:7dcf:7a94 with SMTP id r64-20020a819a43000000b006077dcf7a94mr5535918ywg.6.1709137955942; Wed, 28 Feb 2024 08:32:35 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:2256:57ae:919c:373f]) by smtp.gmail.com with ESMTPSA id l141-20020a0de293000000b00607f8df2097sm2421611ywe.104.2024.02.28.08.32.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 08:32:35 -0800 (PST) Date: Wed, 28 Feb 2024 08:32:34 -0800 From: Yury Norov To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Swiatkowski , Marcin Szycik , Wojciech Drewek , Andy Shevchenko , Rasmus Villemoes , Alexander Potapenko , Jiri Pirko , Ido Schimmel , Przemek Kitszel , Simon Horman , linux-btrfs@vger.kernel.org, dm-devel@redhat.com, ntfs3@lists.linux.dev, linux-s390@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 14/21] lib/bitmap: add compile-time test for __assign_bit() optimization Message-ID: References: <20240201122216.2634007-1-aleksander.lobakin@intel.com> <20240201122216.2634007-15-aleksander.lobakin@intel.com> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240201122216.2634007-15-aleksander.lobakin@intel.com> On Thu, Feb 01, 2024 at 01:22:09PM +0100, Alexander Lobakin wrote: > Commit dc34d5036692 ("lib: test_bitmap: add compile-time > optimization/evaluations assertions") initially missed __assign_bit(), > which led to that quite a time passed before I realized it doesn't get > optimized at compilation time. Now that it does, add test for that just > to make sure nothing will break one day. > To make things more interesting, use bitmap_complement() and > bitmap_full(), thus checking their compile-time evaluation as well. And > remove the misleading comment mentioning the workaround removed recently > in favor of adding the whole file to GCov exceptions. > > Reviewed-by: Przemek Kitszel > Signed-off-by: Alexander Lobakin Signed-off-by: Yury Norov