Re: [PATCH 2/2] ntfs3: remove warning

Christian Brauner
2024-04-15T14:16:03Z

On Mon, Apr 15, 2024 at 01:42:01PM +0200, Johan Hovold wrote:
> On Mon, Apr 15, 2024 at 11:32:50AM +0000, Anton Altaparmakov wrote:
>
> > Had a look at ntfs3 code and it is corrupting your volume. Every such
> > message you are seeing is damaging a file or directory on your volume.
>
> That's what I feared, thanks for confirming.
>
> > I would personally suggest you modify your /etc/fstab to mount
> > read-only. If it is getting simple things like this wrong who knows
> > what else it is doing incorrect...
>
> I fully agree and that's partly also why I asked Christian to make sure
> that the alias fs type is always mounted RO.
>
> But it seems we have a bigger problem here and should just restore the
> old ntfs driver for now.

Hey Linus,

A brief summary:

The removal of the legacy ntfs driver has caused a regression for some
users that rely on the legacy ntfs driver to be available during boot.
The affected user here is Johan (Cc'ed). In addition he's seeing dmesg
warnings that he didn't see before with the legacy ntfs driver.

I see the following options to resolve this:

(1) Since the ntfs3 driver is supposed to serve as a drop-in replacement
for the legacy ntfs driver we should to it the same way we did it
for ext3 and ext4 where ext4 registers itself also for the ext3
driver. In other words, we would register ntfs3 as ntfs3 filesystem
type and as legacy ntfs filesystem type. To make it fully compatible
we also need to make sure it's persistently mounted read-only.

(2) We revert the ntfs driver (for now) as we are in the middle of the
cycle.

If you decide (2) is the right way to go then I would suggest we try the
removal once more next cycle with the proposed change in (1) in place if
you're up for that.

Christian