Re: [PATCH 2/2] ntfs3: remove warning

Konstantin Komarov
2024-04-11T11:03:55Z

On 04.04.2024 11:06, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 25.03.24 13:05, Christian Brauner wrote:
>> On Mon, Mar 25, 2024 at 11:12:00AM +0100, Johan Hovold wrote:
>>> On Mon, Mar 25, 2024 at 09:34:38AM +0100, Christian Brauner wrote:
>>>> This causes visible changes for users that rely on ntfs3 to serve as an
>>>> alternative for the legacy ntfs driver. Print statements such as this
>>>> should probably be made conditional on a debug config option or similar.
>>>>
>>>> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>>>> Cc: Johan Hovold <johan@kernel.org>
>>>> Link: https://lore.kernel.org/r/Zf2zPf5TO5oYt3I3@hovoldconsulting.com
>>>> Signed-off-by: Christian Brauner <brauner@kernel.org>
>>> Tested-by: Johan Hovold <johan+linaro@kernel.org>
>>>
>>> I also see a
>>>
>>> ntfs3: Max link count 4000
>>>
>>> message on mount which wasn't there with NTFS legacy. Is that benign
>>> and should be suppressed too perhaps?
>> We need a reply from the ntfs3 maintainers here.
> Those are known for taken their time to respond -- like we see here, as
> nothing happened for 10 days now. Which makes we wonder: should we at
> least bring the first patch from this series onto the track towards
> mainline?
>
> FWIW, quick side note: just noticed there was another report about the
> "Correct links count -> 1." messages:
> https://lore.kernel.org/all/6215a88a-7d78-4abb-911f-8a3e7033da3e@gmx.com/
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> #regzbot duplicate:
> https://lore.kernel.org/all/6215a88a-7d78-4abb-911f-8a3e7033da3e@gmx.com/
> #regzbot poke
>
Hello Christian, Johan, all,

There is no problem in suppressing the output of any messages during
mounting, like:

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index cef5467fd928..4643b06b1550 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1804,8 +1804,6 @@ static int __init init_ntfs_fs(void)
{
int err;
-       pr_info("ntfs3: Max link count %u\n", NTFS_LINK_MAX);
-
if (IS_ENABLED(CONFIG_NTFS3_FS_POSIX_ACL))
pr_info("ntfs3: Enabled Linux POSIX ACLs support\n");
if (IS_ENABLED(CONFIG_NTFS3_64BIT_CLUSTER))

Messages like this:

diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
index eb7a8c9fba01..8cc94a6a97ed 100644
--- a/fs/ntfs3/inode.c
+++ b/fs/ntfs3/inode.c
@@ -424,7 +424,6 @@ static struct inode *ntfs_read_mft(struct inode *inode,
if (names != le16_to_cpu(rec->hard_links)) {
/* Correct minor error on the fly. Do not mark inode as dirty. */
-        ntfs_inode_warn(inode, "Correct links count -> %u.", names);
rec->hard_links = cpu_to_le16(names);
ni->mi.dirty = true;
}

can also be suppressed for the sake of seamless transition from a remote
NTFS driver.
However, I believe that file system corrections should be reported to
the user.