From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] fs/ntfs3: Fix compilation error
Date: Wed, 24 Apr 2024 17:48:35 +0300 [thread overview]
Message-ID: <Zikbw9Z5p4XDiyMW@smile.fi.intel.com> (raw)
In-Reply-To: <20240423205634.3673120-1-andriy.shevchenko@linux.intel.com>
On Tue, Apr 23, 2024 at 11:56:34PM +0300, Andy Shevchenko wrote:
> Compilation with CONFIG_WERROR=y, which is default, is broken:
>
> fs/ntfs3/super.c:1247:26: error: variable 'attr' is uninitialized when used here [-Werror,-Wuninitialized]
>
> attr = ni_find_attr(ni, attr, NULL, ATTR_VOL_INFO, NULL, 0, NULL, NULL);
> ^~~~
> Pass NULL instead.
Hmm... Something weird is going on. I'm looking now into the code and
have no clue why compiler is not okay with this code. The proposed patch
seems incorrect anyway.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-24 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 20:56 [PATCH v1 1/1] fs/ntfs3: Fix compilation error Andy Shevchenko
2024-04-24 14:48 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zikbw9Z5p4XDiyMW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox