Re: [PATCH] fs: ntfs3: fix Using uninitialized value n when calling indx_read

[Konstantin Komarov <almaz.alexandrovich@paragon-software.com>]

On 4/22/22 11:33, yan wrote:
> 
> 
> 
>     It's not a mistake, I can't send patchs with my company's email due to some security issues。
> 
>     The CWE bug were detected by a static code scanning tool called CodeS of my company（I don't kown its real name）.
>     The CodeS reports:
>     Use of an uninitialized variable(CWE-457)
>     Using uninitialized value "n" when calling indx_read.
> 
> 
>     commit messages is as below:
>     This CWE bug were detected by a static code scanning tool，
>     Fix using unitialized value n when calling indx_read
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> At 2022-04-21 01:50:27, "Kari Argillander" <kari.argillander@gmail.com> wrote:
>> This patch is sended from address chinayanlei2002@163.com you need to
>> send it from yan_lei@dahuatech.com this was probably mistake?
>>
>> Also please write commit message. Always good to write how did you spot
>> this and what message some analyzer showed to you. This way everyone
>> else will can verify and maybe even learn to use new tools. This also
>> looks like it really fix something so this needs fix tag so it can be
>> easily back ported to stable.
>>
>> On 10.4.2022 9.09, chinayanlei2002@163.com wrote:
>>> From: Yan Lei <yan_lei@dahuatech.com>
>>>
>>> Signed-off-by: Yan Lei <yan_lei@dahuatech.com>
>>> ---
>>>    fs/ntfs3/index.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
>>> index 6f81e3a49..76ebea253 100644
>>> --- a/fs/ntfs3/index.c
>>> +++ b/fs/ntfs3/index.c
>>> @@ -1994,7 +1994,7 @@ static int indx_free_children(struct ntfs_index *indx, struct ntfs_inode *ni,
>>>    			      const struct NTFS_DE *e, bool trim)
>>>    {
>>>    	int err;
>>> -	struct indx_node *n;
>>> +	struct indx_node *n = NULL;
>>>    	struct INDEX_HDR *hdr;
>>>    	CLST vbn = de_get_vbn(e);
>>>    	size_t i;

I've changed author email to chinayanlei2002@163.com and applied patch.
Thanks for catching this!