From: David Hunter <david.hunter.linux@gmail.com>
To: Raphael Pinsonneault-Thibeault <rpthibeault@gmail.com>,
almaz.alexandrovich@paragon-software.com
Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org,
syzbot+7a2ba6b7b66340cff225@syzkaller.appspotmail.com
Subject: Re: [PATCH] ntfs3: fix uninit memory after failed mi_read in mi_format_new
Date: Sun, 28 Sep 2025 11:25:14 -0400 [thread overview]
Message-ID: <c5194ece-e402-49ba-8b15-674c782b1a6c@gmail.com> (raw)
In-Reply-To: <20250925203701.223744-2-rpthibeault@gmail.com>
On 9/25/25 16:36, Raphael Pinsonneault-Thibeault wrote:
> - } else if (mi_read(mi, is_mft)) {
> - ;
> - } else if (rec->rhdr.sign == NTFS_FILE_SIGNATURE) {
> - /* Record is reused. Update its sequence number. */
> - seq = le16_to_cpu(rec->seq) + 1;
> - if (!seq)
> - seq = 1;
> + } else {
> + err = mi_read(mi, is_mft);
> + if (err) {
> + return err;
> + }
> +
> + if (rec->rhdr.sign == NTFS_FILE_SIGNATURE) {
> + /* Record is reused. Update its sequence number. */
> + seq = le16_to_cpu(rec->seq) + 1;
> + if (!seq)
> + seq = 1;
> + }
How was this tested?
prev parent reply other threads:[~2025-09-28 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 20:36 [PATCH] ntfs3: fix uninit memory after failed mi_read in mi_format_new Raphael Pinsonneault-Thibeault
2025-09-28 15:17 ` David Hunter
2025-09-28 15:25 ` David Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5194ece-e402-49ba-8b15-674c782b1a6c@gmail.com \
--to=david.hunter.linux@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=rpthibeault@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+7a2ba6b7b66340cff225@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox