From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <ntfs3@lists.linux.dev>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] fs/ntfs3: Uninitialized variable bug in ntfs_d_compare()
Date: Mon, 26 Dec 2022 19:15:57 +0400 [thread overview]
Message-ID: <d14a1700-e36a-9fc7-ffc3-464de93cd355@paragon-software.com> (raw)
In-Reply-To: <Y0kug+IlQhJyyg25@kili>
On 14.10.2022 13:40, Dan Carpenter wrote:
> Smatch detected an uninitialized variable bug:
>
> fs/ntfs3/namei.c:487 ntfs_d_compare() error: uninitialized symbol 'uni1'
>
> Fixes: a3a956c78efa ("fs/ntfs3: Add option "nocase"")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/ntfs3/namei.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c
> index 315763eb05ff..5d3a6ce3f05f 100644
> --- a/fs/ntfs3/namei.c
> +++ b/fs/ntfs3/namei.c
> @@ -431,10 +431,8 @@ static int ntfs_d_compare(const struct dentry *dentry, unsigned int len1,
>
> /* First try fast implementation. */
> for (;;) {
> - if (!lm--) {
> - ret = len1 == len2 ? 0 : 1;
> - goto out;
> - }
> + if (!lm--)
> + return len1 == len2 ? 0 : 1;
>
> if ((c1 = *n1++) == (c2 = *n2++))
> continue;
> @@ -442,10 +440,8 @@ static int ntfs_d_compare(const struct dentry *dentry, unsigned int len1,
> if (c1 >= 0x80 || c2 >= 0x80)
> break;
>
> - if (toupper(c1) != toupper(c2)) {
> - ret = 1;
> - goto out;
> - }
> + if (toupper(c1) != toupper(c2))
> + return 1;
> }
>
> /*
Thanks for work, this bug has already been fixed:
https://lore.kernel.org/ntfs3/20221004232359.285685-1-nathan@kernel.org/
prev parent reply other threads:[~2022-12-26 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 9:40 [PATCH] fs/ntfs3: Uninitialized variable bug in ntfs_d_compare() Dan Carpenter
2022-12-26 15:15 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d14a1700-e36a-9fc7-ffc3-464de93cd355@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox