Re: [PATCH V4 07/17] nvdimm/label: Add region label delete support

[Neeraj Kumar <s.neeraj@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

On 19/11/25 12:50PM, Dave Jiang wrote:
>
>
>On 11/19/25 12:52 AM, Neeraj Kumar wrote:
>> Create export routine nd_region_label_delete() used for deleting
>> region label from LSA. It will be used later from CXL subsystem
>>
>> Signed-off-by: Neeraj Kumar <s.neeraj@samsung.com>
>
>Just one small thing below, otherwise
>Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>
>> ---
>>  drivers/nvdimm/label.c          | 76 ++++++++++++++++++++++++++++++---
>>  drivers/nvdimm/label.h          |  1 +
>>  drivers/nvdimm/namespace_devs.c | 12 ++++++
>>  drivers/nvdimm/nd.h             |  6 +++
>>  include/linux/libnvdimm.h       |  1 +
>>  5 files changed, 90 insertions(+), 6 deletions(-)
>>

<snip>

>>
>> +int nd_region_label_delete(struct nd_region *nd_region)
>> +{
>> +	int rc;
>> +
>> +	nvdimm_bus_lock(&nd_region->dev);
>
>You can use the new nvdimm_bus guard() now.
>
>guard(nvdimm_bus)(&nd_region->dev);
>
>DJ

Hi Dave, Thanks for RB tag, I have fixed it in V5.


Regards,
Neeraj

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]