From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 181F772 for ; Tue, 19 Oct 2021 07:23:37 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id C6E1568BFE; Tue, 19 Oct 2021 09:23:26 +0200 (CEST) Date: Tue, 19 Oct 2021 09:23:26 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , no@lst.de, To-header@lst.de, on@lst.de, "input <"@lst.de;, Dan Williams , Mike Snitzer , Ira Weiny , dm-devel@redhat.com, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 06/11] xfs: factor out a xfs_setup_dax helper Message-ID: <20211019072326.GA23171@lst.de> References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-7-hch@lst.de> <20211018164351.GT24307@magnolia> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018164351.GT24307@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote: > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -339,6 +339,32 @@ xfs_buftarg_is_dax( > > bdev_nr_sectors(bt->bt_bdev)); > > } > > > > +static int > > +xfs_setup_dax( > > /me wonders if this should be named xfs_setup_dax_always, since this > doesn't handle the dax=inode mode? Sure, why not. > The only reason I bring that up is that Eric reminded me a while ago > that we don't actually print any kind of EXPERIMENTAL warning for the > auto-detection behavior. Yes, I actually noticed that as well when preparing this series.