From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60E0F2C81 for ; Wed, 24 Nov 2021 06:37:38 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 4D2F768AFE; Wed, 24 Nov 2021 07:37:35 +0100 (CET) Date: Wed, 24 Nov 2021 07:37:35 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Dan Williams , Mike Snitzer , Ira Weiny , dm-devel@redhat.com, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 08/29] dax: remove dax_capable Message-ID: <20211124063735.GB6889@lst.de> References: <20211109083309.584081-1-hch@lst.de> <20211109083309.584081-9-hch@lst.de> <20211123223123.GF266024@magnolia> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211123223123.GF266024@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Nov 23, 2021 at 02:31:23PM -0800, Darrick J. Wong wrote: > > - struct super_block *sb = mp->m_super; > > - > > - if (!xfs_buftarg_is_dax(sb, mp->m_ddev_targp) && > > - (!mp->m_rtdev_targp || !xfs_buftarg_is_dax(sb, mp->m_rtdev_targp))) { > > + if (!mp->m_ddev_targp->bt_daxdev && > > + (!mp->m_rtdev_targp || !mp->m_rtdev_targp->bt_daxdev)) { > > Nit: This ^ paren should be indented one more column because it's a > sub-clause of the if() test. Done. > Nit: xfs_alert() already adds a newline to the end of the format string. Already done in the current tree.