From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E7872C9C for ; Mon, 31 Jan 2022 18:14:37 +0000 (UTC) Received: from fraeml711-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Jnbgq4CWSz67Z6v; Tue, 1 Feb 2022 02:09:59 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml711-chm.china.huawei.com (10.206.15.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 31 Jan 2022 19:14:34 +0100 Received: from localhost (10.47.73.212) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.21; Mon, 31 Jan 2022 18:14:34 +0000 Date: Mon, 31 Jan 2022 18:14:28 +0000 From: Jonathan Cameron To: Dan Williams CC: , , Subject: Re: [PATCH v3 25/40] cxl/core/port: Remove @host argument for dport + decoder enumeration Message-ID: <20220131181428.00004da8@Huawei.com> In-Reply-To: <164298425201.3018233.647136583483232467.stgit@dwillia2-desk3.amr.corp.intel.com> References: <164298411792.3018233.7493009997525360044.stgit@dwillia2-desk3.amr.corp.intel.com> <164298425201.3018233.647136583483232467.stgit@dwillia2-desk3.amr.corp.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.73.212] X-ClientProxiedBy: lhreml704-chm.china.huawei.com (10.201.108.53) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected On Sun, 23 Jan 2022 16:30:52 -0800 Dan Williams wrote: > Now that dport and decoder enumeration is centralized in the port > driver, the @host argument for these helpers can be made implicit. For > the root port the host is the port's uport device (ACPI0017 for > cxl_acpi), and for all other descendant ports the devm context is the > parent of @port. > > Signed-off-by: Dan Williams Looks good to me. FWIW given it's kind of an obvious one. Reviewed-by: Jonathan Cameron