From: alison.schofield@intel.com
To: Vishal Verma <vishal.l.verma@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>, nvdimm@lists.linux.dev
Subject: [ndctl PATCH] libdaxctl: free resource allocated with asprintf()
Date: Thu, 3 Mar 2022 16:01:33 -0800 [thread overview]
Message-ID: <20220304000133.1053883-1-alison.schofield@intel.com> (raw)
From: Alison Schofield <alison.schofield@intel.com>
Static analysis reported this resource leak.
Fixes: d07508a0cc3c ("libdaxctl: add daxctl_region_create_dev()")
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
daxctl/lib/libdaxctl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c
index f173bbb7c514..5703992f5b88 100644
--- a/daxctl/lib/libdaxctl.c
+++ b/daxctl/lib/libdaxctl.c
@@ -624,10 +624,9 @@ DAXCTL_EXPORT int daxctl_region_create_dev(struct daxctl_region *region)
}
rc = sysfs_write_attr(ctx, path, num_devices);
- if (rc)
- return rc;
+ free(num_devices);
- return 0;
+ return rc;
}
DAXCTL_EXPORT int daxctl_region_destroy_dev(struct daxctl_region *region,
base-commit: 3b5fb8b6428dfaab39bab58d67412427f514c1f4
--
2.31.1
reply other threads:[~2022-03-03 23:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304000133.1053883-1-alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox