From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE6017A for ; Thu, 10 Mar 2022 07:18:53 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 1652468B05; Thu, 10 Mar 2022 08:09:49 +0100 (CET) Date: Thu, 10 Mar 2022 08:09:48 +0100 From: Christoph Hellwig To: Dan Williams Cc: nvdimm@lists.linux.dev, robert.hu@linux.intel.com, vishal.l.verma@intel.com, hch@lst.de, linux-acpi@vger.kernel.org Subject: Re: [PATCH 1/6] nvdimm/region: Fix default alignment for small regions Message-ID: <20220310070948.GA25138@lst.de> References: <164688415599.2879318.17035042246954533659.stgit@dwillia2-desk3.amr.corp.intel.com> <164688416128.2879318.17890707310125575258.stgit@dwillia2-desk3.amr.corp.intel.com> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164688416128.2879318.17890707310125575258.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Mar 09, 2022 at 07:49:21PM -0800, Dan Williams wrote: > In preparation for removing BLK aperture support the NVDIMM unit tests > discovered that the default alignment can be set higher than the > capacity of the region. Fall back to PAGE_SIZE in that case. > > Given this has not been seen in the wild, elide notifying -stable. Looks good, Reviewed-by: Christoph Hellwig