From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 196B16AA0 for ; Wed, 20 Jul 2022 17:46:19 +0000 (UTC) Received: from fraeml702-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Lp3220M8cz67mdF; Thu, 21 Jul 2022 01:42:50 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml702-chm.china.huawei.com (10.206.15.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.24; Wed, 20 Jul 2022 19:46:16 +0200 Received: from localhost (10.81.205.121) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 20 Jul 2022 18:46:15 +0100 Date: Wed, 20 Jul 2022 18:46:14 +0100 From: Jonathan Cameron To: Dan Williams CC: , , , Subject: Re: [PATCH v2 27/28] cxl/pmem: Fix offline_nvdimm_bus() to offline by bridge Message-ID: <20220720184614.00007803@Huawei.com> In-Reply-To: <165784339569.1758207.1557084545278004577.stgit@dwillia2-xfh.jf.intel.com> References: <165784324066.1758207.15025479284039479071.stgit@dwillia2-xfh.jf.intel.com> <165784339569.1758207.1557084545278004577.stgit@dwillia2-xfh.jf.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.81.205.121] X-ClientProxiedBy: lhreml754-chm.china.huawei.com (10.201.108.204) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected On Thu, 14 Jul 2022 17:03:15 -0700 Dan Williams wrote: > Be careful to only disable cxl_pmem objects related to a given > cxl_nvdimm_bridge. Otherwise, offline_nvdimm_bus() reaches across CXL > domains and disables more than is expected. > > Fixes: 21083f51521f ("cxl/pmem: Register 'pmem' / cxl_nvdimm devices") > Signed-off-by: Dan Williams All comments on v1 were addressed in your reply so LGTM Reviewed-by: Jonathan Cameron