From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A183390 for ; Sat, 18 Feb 2023 00:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676680837; x=1708216837; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=4mXc8aXzC2a5QQ64fr2TipWZlLxkknQajmWzGZWeva0=; b=U8BgfDbzk3iWL/1mgtVQKAUcDmlO2+Sp8ZXCUjW2lMxSvU3LAURWTdHp q9oEOWukZI9/Mb3JedMHsO06JvU/XKJQmZ3NMnsN5+MTrNwhj9+KP3Fr5 lRzdProUAwk/pdizEHidD0K0tBrrCjqtIFRC0jX+hqnJHbeNVaT93aP3j JyeDGMl5vQYtvuxCVWJAS3Ex+9dyXcnbtUNt//TloOgK0xmWuqw4hJFcu MZW6AljYJe7gsPPjJJadmF5rqLoB3/rdXA55dRd0nMiZ4cT6jRD2Ux00z BA3yJBAnA7/UKEOE8RQqtfiehO8J9BbPCb2In3xLXLxjalaryHBuUIYmK w==; X-IronPort-AV: E=McAfee;i="6500,9779,10624"; a="311754227" X-IronPort-AV: E=Sophos;i="5.97,306,1669104000"; d="scan'208";a="311754227" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2023 16:40:32 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10624"; a="844749009" X-IronPort-AV: E=Sophos;i="5.97,306,1669104000"; d="scan'208";a="844749009" Received: from basavana-mobl.amr.corp.intel.com (HELO vverma7-desk1.local) ([10.209.2.127]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2023 16:40:32 -0800 From: Vishal Verma Date: Fri, 17 Feb 2023 17:40:24 -0700 Subject: [PATCH ndctl 3/3] test/cxl-security.sh: avoid intermittent failures due to sasync probe Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230217-coverity-fixes-v1-3-043fac896a40@intel.com> References: <20230217-coverity-fixes-v1-0-043fac896a40@intel.com> In-Reply-To: <20230217-coverity-fixes-v1-0-043fac896a40@intel.com> To: linux-cxl@vger.kernel.org Cc: nvdimm@lists.linux.dev, Dave Jiang , Dan Williams , Vishal Verma X-Mailer: b4 0.13-dev-ada30 X-Developer-Signature: v=1; a=openpgp-sha256; l=896; i=vishal.l.verma@intel.com; h=from:subject:message-id; bh=4mXc8aXzC2a5QQ64fr2TipWZlLxkknQajmWzGZWeva0=; b=owGbwMvMwCXGf25diOft7jLG02pJDMkf5OqLBFx1l6UXlB2W6bmTu9Zyy50dsq83SVoWZz1Yz xYg7D+7o5SFQYyLQVZMkeXvno+Mx+S25/MEJjjCzGFlAhnCwMUpABN5y8Lwhz8r8Gl//o/jXjWR vz0fZByLcvvMuVdn844g4Y5tal+yfRkZemJfe3efblUuTnmvsXJP0bX55vHzp04892vh144FLXd WcQMA X-Developer-Key: i=vishal.l.verma@intel.com; a=openpgp; fpr=F8682BE134C67A12332A2ED07AFA61BEA3B84DFF This test failed intermittently because the ndctl-list operation right after a 'modprobe cxl_test' could race the actual nmem devices getting loaded. Since CXL device probes are asynchronous, and cxl_acpi might've kicked off a cxl_bus_rescan(), a cxl_flush() (via cxl_wait_probe()) can ensure everything is loaded. Add a plain cxl-list right after the modprobe to allow for a flush/wait cycle. Cc: Dave Jiang Suggested-by: Dan Williams Signed-off-by: Vishal Verma --- test/security.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test/security.sh b/test/security.sh index 04f630e..fb04aa6 100755 --- a/test/security.sh +++ b/test/security.sh @@ -225,6 +225,7 @@ if [ "$uid" -ne 0 ]; then fi modprobe "$KMOD_TEST" +cxl list setup check_prereq "keyctl" rc=1 -- 2.39.1