Re: [PATCH V5 15/17] cxl/pmem_region: Add sysfs attribute cxl region label updation/deletion

Neeraj Kumar
2026-01-23T11:25:55Z

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

On 15/01/26 06:21PM, Jonathan Cameron wrote:
>On Fri, 9 Jan 2026 18:14:35 +0530
>Neeraj Kumar <s.neeraj@samsung.com> wrote:
>
>> Using these attributes region label is added/deleted into LSA. These
>> attributes are called from userspace (ndctl) after region creation.
>>
>> Signed-off-by: Neeraj Kumar <s.neeraj@samsung.com>
>One wrong field name.
>
>With that and the version number updated as Dave pointed out
>Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

Thanks Jonathan for RB tag.

>
>
>> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
>> index 6ac3b40cb5ff..8c76c4a981bf 100644
>> --- a/drivers/cxl/cxl.h
>> +++ b/drivers/cxl/cxl.h
>
>> /**
>> * struct cxl_region_params - region settings
>> * @state: allow the driver to lockdown further parameter changes
>> + * @state: region label state
>
>wrong name.

Fixed it in V6

>
>Run scripts/kernel-doc over files you add documentation to and it'll
>tell you when you get anything like this wrong.

I ran it but its not showing any error and displaying the wrong name
only.

Regards,
Neeraj

>
>> * @uuid: unique id for persistent regions
>> * @interleave_ways: number of endpoints in the region
>> * @interleave_granularity: capacity each endpoint contributes to a stripe
>> @@ -488,6 +494,7 @@ enum cxl_config_state {
>> */
>> struct cxl_region_params {
>> enum cxl_config_state state;
>> + enum region_label_state state_region_label;
>> uuid_t uuid;
>> int interleave_ways;
>> int interleave_granularity;
>

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]