public inbox for nvdimm@lists.linux.dev
 help / color / mirror / Atom feed
From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Neeraj Kumar <s.neeraj@samsung.com>
Cc: <linux-cxl@vger.kernel.org>, <nvdimm@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>, <gost.dev@samsung.com>,
	<a.manzanares@samsung.com>, <vishak.g@samsung.com>,
	<neeraj.kernel@gmail.com>
Subject: Re: [PATCH V5 05/17] nvdimm/label: Skip region label during ns label DPA reservation
Date: Thu, 15 Jan 2026 17:56:39 +0000	[thread overview]
Message-ID: <20260115175639.00004f3a@huawei.com> (raw)
In-Reply-To: <20260109124437.4025893-6-s.neeraj@samsung.com>

On Fri,  9 Jan 2026 18:14:25 +0530
Neeraj Kumar <s.neeraj@samsung.com> wrote:

> CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section
> 9.13.2.5. If Namespace label is present in LSA during
> nvdimm_probe() then dimm-physical-address(DPA) reservation is
> required. But this reservation is not required by cxl region
> label. Therefore if LSA scanning finds any region label, skip it.
> 
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Neeraj Kumar <s.neeraj@samsung.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

> ---
>  drivers/nvdimm/label.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c
> index 9854cb45fb62..169692dfa12c 100644
> --- a/drivers/nvdimm/label.c
> +++ b/drivers/nvdimm/label.c
> @@ -469,6 +469,14 @@ int nd_label_reserve_dpa(struct nvdimm_drvdata *ndd)
>  		lsa_label = to_lsa_label(ndd, slot);
>  		nd_label = &lsa_label->ns_label;
>  
> +		/*
> +		 * Skip region label. If LSA label is region label
> +		 * then it don't require dimm-physical-address(DPA)
> +		 * reservation. Whereas its required for namespace label
> +		 */
> +		if (is_region_label(ndd, lsa_label))
> +			continue;
> +
>  		if (!slot_valid(ndd, lsa_label, slot))
>  			continue;
>  


  reply	other threads:[~2026-01-15 17:56 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260109124454epcas5p4513168fdb4253ef1c5ac1656985417fd@epcas5p4.samsung.com>
2026-01-09 12:44 ` [PATCH V5 00/17] Add CXL LSA 2.1 format support in nvdimm and cxl pmem Neeraj Kumar
2026-01-09 12:44   ` [PATCH V5 01/17] nvdimm/label: Introduce NDD_REGION_LABELING flag to set region label Neeraj Kumar
2026-01-14 21:22     ` Ira Weiny
2026-01-09 12:44   ` [PATCH V5 02/17] nvdimm/label: CXL labels skip the need for 'interleave-set cookie' Neeraj Kumar
2026-01-09 12:44   ` [PATCH V5 03/17] nvdimm/label: Add namespace/region label support as per LSA 2.1 Neeraj Kumar
2026-01-15 17:45     ` Jonathan Cameron
2026-01-23 10:57       ` Neeraj Kumar
2026-01-21  0:35     ` Ira Weiny
2026-01-09 12:44   ` [PATCH V5 04/17] nvdimm/label: Include region label in slot validation Neeraj Kumar
2026-01-14 21:20     ` Ira Weiny
2026-01-23 11:02       ` Neeraj Kumar
2026-01-15 17:55     ` Jonathan Cameron
2026-01-21  0:38     ` Ira Weiny
2026-01-09 12:44   ` [PATCH V5 05/17] nvdimm/label: Skip region label during ns label DPA reservation Neeraj Kumar
2026-01-15 17:56     ` Jonathan Cameron [this message]
2026-01-21  0:41     ` Ira Weiny
2026-01-23 11:05       ` Neeraj Kumar
2026-01-09 12:44   ` [PATCH V5 06/17] nvdimm/label: Preserve region label during namespace creation Neeraj Kumar
2026-01-15 17:59     ` Jonathan Cameron
2026-01-21  0:43     ` Ira Weiny
2026-01-09 12:44   ` [PATCH V5 07/17] nvdimm/label: Add region label delete support Neeraj Kumar
2026-01-21  0:44     ` Ira Weiny
2026-01-09 12:44   ` [PATCH V5 08/17] nvdimm/label: Preserve cxl region information from region label Neeraj Kumar
2026-01-15 18:03     ` Jonathan Cameron
2026-01-23 11:08       ` Neeraj Kumar
2026-01-21  0:45     ` Ira Weiny
2026-01-09 12:44   ` [PATCH V5 09/17] nvdimm/label: Export routine to fetch region information Neeraj Kumar
2026-01-15 18:03     ` Jonathan Cameron
2026-01-21  0:46     ` Ira Weiny
2026-01-23 11:11       ` Neeraj Kumar
2026-01-23 11:20       ` Neeraj Kumar
2026-01-09 12:44   ` [PATCH V5 10/17] cxl/mem: Refactor cxl pmem region auto-assembling Neeraj Kumar
2026-01-15 18:08     ` Jonathan Cameron
2026-01-23 11:14       ` Neeraj Kumar
2026-01-09 12:44   ` [PATCH V5 11/17] cxl/region: Add devm_cxl_pmem_add_region() for pmem region creation Neeraj Kumar
2026-01-15 18:17     ` Jonathan Cameron
2026-01-23 11:17       ` Neeraj Kumar
2026-01-09 12:44   ` [PATCH V5 12/17] cxl/pmem: Preserve region information into nd_set Neeraj Kumar
2026-01-15 18:18     ` Jonathan Cameron
2026-01-09 12:44   ` [PATCH V5 13/17] cxl/pmem_region: Prep patch to accommodate pmem_region attributes Neeraj Kumar
2026-01-09 12:44   ` [PATCH V5 14/17] cxl/pmem_region: Introduce CONFIG_CXL_PMEM_REGION for core/pmem_region.c Neeraj Kumar
2026-01-15 18:19     ` Jonathan Cameron
2026-01-09 12:44   ` [PATCH V5 15/17] cxl/pmem_region: Add sysfs attribute cxl region label updation/deletion Neeraj Kumar
2026-01-14 17:00     ` Dave Jiang
2026-01-23 11:22       ` Neeraj Kumar
2026-01-15 18:21     ` Jonathan Cameron
2026-01-23 11:25       ` Neeraj Kumar
2026-01-09 12:44   ` [PATCH V5 16/17] cxl/pmem_region: Create pmem region using information parsed from LSA Neeraj Kumar
2026-01-15 18:28     ` Jonathan Cameron
2026-01-23 11:28       ` Neeraj Kumar
2026-01-09 12:44   ` [PATCH V5 17/17] cxl/pmem: Add CXL LSA 2.1 support in cxl pmem Neeraj Kumar
2026-01-15 18:29     ` Jonathan Cameron
2026-01-21 15:37   ` [PATCH V5 00/17] Add CXL LSA 2.1 format support in nvdimm and " Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260115175639.00004f3a@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=a.manzanares@samsung.com \
    --cc=gost.dev@samsung.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neeraj.kernel@gmail.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=s.neeraj@samsung.com \
    --cc=vishak.g@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox