From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Gregory Price <gourry@gourry.net>, Dave Jiang <dave.jiang@intel.com>
Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org,
driver-core@lists.linux.dev, linux-kselftest@vger.kernel.org,
kernel-team@meta.com, osalvador@suse.de,
gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org,
djbw@kernel.org, vishal.l.verma@intel.com,
alison.schofield@intel.com, akpm@linux-foundation.org,
ljs@kernel.org, liam@infradead.org, vbabka@kernel.org,
rppt@kernel.org, surenb@google.com, mhocko@suse.com,
shuah@kernel.org, iweiny@kernel.org,
Smita.KoralahalliChannabasappa@amd.com, apopple@nvidia.com
Subject: Re: [PATCH v6 02/10] mm/memory_hotplug: add mhp_online_type_to_str() and export string helpers
Date: Fri, 10 Jul 2026 14:44:48 +0200 [thread overview]
Message-ID: <2116d58d-48df-488f-88d7-523298f78e62@kernel.org> (raw)
In-Reply-To: <alAZLBqgUEZliwk_@gourry-fedora-PF4VCD3F>
On 7/9/26 23:57, Gregory Price wrote:
> On Thu, Jul 09, 2026 at 02:08:43PM -0700, Dave Jiang wrote:
>>
>>> extern int mhp_online_type_from_str(const char *str);
>>> +const char *mhp_online_type_to_str(int online_type);
>>
>> Does this need to also be 'extern'?
>>
>> DJ
>>
>
> General policy i've understood is: "No new extern"
Yes, and removing existing ones as we touch the code.
--
Cheers,
David
next prev parent reply other threads:[~2026-07-10 12:44 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 21:18 [PATCH v6 00/10] dax/kmem: atomic whole-device hotplug via sysfs Gregory Price
2026-06-30 21:18 ` [PATCH v6 01/10] mm/memory: add memory_block_aligned_range() helper Gregory Price
2026-07-09 17:58 ` Dave Jiang
2026-06-30 21:18 ` [PATCH v6 02/10] mm/memory_hotplug: add mhp_online_type_to_str() and export string helpers Gregory Price
2026-07-01 8:30 ` David Hildenbrand (Arm)
2026-07-09 17:59 ` Dave Jiang
2026-07-09 21:08 ` Dave Jiang
2026-07-09 21:57 ` Gregory Price
2026-07-10 12:44 ` David Hildenbrand (Arm) [this message]
2026-06-30 21:18 ` [PATCH v6 03/10] mm/memory_hotplug: pass online_type to online_memory_block() via arg Gregory Price
2026-07-09 18:22 ` Dave Jiang
2026-06-30 21:18 ` [PATCH v6 04/10] mm/memory_hotplug: export mhp_get_default_online_type Gregory Price
2026-07-09 18:30 ` Dave Jiang
2026-06-30 21:18 ` [PATCH v6 05/10] mm/memory_hotplug: add __add_memory_driver_managed() with online_type arg Gregory Price
2026-07-09 18:48 ` Dave Jiang
2026-06-30 21:18 ` [PATCH v6 06/10] mm/memory_hotplug: add offline_and_remove_memory_ranges() Gregory Price
2026-07-01 8:32 ` David Hildenbrand (Arm)
2026-07-09 8:45 ` Richard Cheng
2026-07-09 15:06 ` Gregory Price
2026-07-09 17:15 ` Gregory Price
2026-07-09 18:53 ` Dave Jiang
2026-06-30 21:18 ` [PATCH v6 07/10] dax: plumb hotplug online_type through dax Gregory Price
2026-07-09 21:07 ` Dave Jiang
2026-07-09 21:46 ` Dan Williams (nvidia)
2026-07-09 22:08 ` Gregory Price
2026-07-10 1:30 ` Gregory Price
2026-07-11 0:44 ` Dan Williams (nvidia)
2026-06-30 21:18 ` [PATCH v6 08/10] dax/kmem: extract hotplug/hotremove helper functions Gregory Price
2026-07-09 21:44 ` Dave Jiang
2026-07-09 21:57 ` Gregory Price
2026-06-30 21:18 ` [PATCH v6 09/10] dax/kmem: add sysfs interface for atomic whole-device hotplug Gregory Price
2026-06-30 21:32 ` sashiko-bot
2026-06-30 22:14 ` Gregory Price
2026-07-01 6:13 ` Hannes Reinecke
2026-07-01 6:23 ` Gregory Price
2026-07-09 8:07 ` Richard Cheng
2026-07-09 14:57 ` Gregory Price
2026-07-09 22:14 ` Dave Jiang
2026-07-09 22:22 ` Gregory Price
2026-07-09 22:36 ` Dan Williams (nvidia)
2026-07-09 23:06 ` Gregory Price
2026-07-09 23:57 ` Dan Williams (nvidia)
2026-07-10 3:08 ` Gregory Price
2026-06-30 21:18 ` [PATCH v6 10/10] selftests/dax: add dax/kmem hotplug sysfs regression test Gregory Price
2026-07-09 8:20 ` Richard Cheng
2026-07-09 15:02 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2116d58d-48df-488f-88d7-523298f78e62@kernel.org \
--to=david@kernel.org \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=apopple@nvidia.com \
--cc=dakr@kernel.org \
--cc=dave.jiang@intel.com \
--cc=djbw@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gourry@gourry.net \
--cc=gregkh@linuxfoundation.org \
--cc=iweiny@kernel.org \
--cc=kernel-team@meta.com \
--cc=liam@infradead.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=nvdimm@lists.linux.dev \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox