From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-93.mta1.migadu.com [95.215.58.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53313CFF55 for ; Thu, 3 Sep 2026 06:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788416153; cv=none; b=bt4aLf9z3E6qIQsRvirQ9BgNQ10N0unW23CKJOpSzIrfd7UkBalWkUB7OKlikumqT5+1jgD+7/0hdvtZvhyD5NTxmQIxQ7OuicWZxovPsHEFQLaX8jSAxvIkCuBSRMjPBh1/4885yTeHmV5ATMV4BCn2XZeD8KvK7rr/f3mVzcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788416153; c=relaxed/simple; bh=ozxwDUyi2Jrz5fmCCNaXY1cqHon49rF3ga5YguJGK5k=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=suxX7ppBsp0R34Q1gD7bxF6n0Xsta9F0SfT3jM7XWPxBj9E6SRj6vdKKMmcuHMTNp4x2DTiXKNe0bVIcsluFh2ICmSWEBiENurnlkIMYzGEhbsiMmnZoPf03URnpc5MZUQiaDWf0yZ1qVnNoKlZlkLOOESlbg/3iPweJnzz3/A4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=jZnAZkwp; arc=none smtp.client-ip=95.215.58.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="jZnAZkwp" X-Envelope-To: nvdimm@lists.linux.dev DKIM-Signature: a=rsa-sha256; bh=ozxwDUyi2Jrz5fmCCNaXY1cqHon49rF3ga5YguJGK5k=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788416148; v=1; x=1789020948; b=jZnAZkwpZy2pYbEnZW1HPAz40kg78Khchq3n5lbJWfY9IDPXB8b7wgWYs5yJSMTPi8viViKA 5WxbYLwLZopmAN3rrIFNe95bZdUeV4mJRts++m9QgK+NHAo24Be00+kjwQ+tLWvtrCObLiJw3g/ E1rK6qB162Q0wTUftavmWmxM= X-Envelope-To: nvdimm@lists.linux.dev Received: by mta10.migadu.com with ESMTPS id c28caae6b09f6708; Thu, 03 Sep 2026 06:15:48 +0000 X-Mizu-Trace-ID: c28caae6b09f6708 X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.1\)) Subject: Re: [PATCH 1/2] mm/page-flags: Define HWPoison test-and-change helpers unconditionally From: Muchun Song In-Reply-To: <20260903053535.17611-2-kaitao.cheng@linux.dev> Date: Thu, 3 Sep 2026 14:15:27 +0800 Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Dan Williams , Vishal Verma , Dave Jiang , Alison Schofield , Ira Weiny , linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, Kaitao Cheng Content-Transfer-Encoding: 7bit Message-Id: <2F4B7639-9C33-4907-BCBE-C6C9DB845D7F@linux.dev> References: <20260903053535.17611-1-kaitao.cheng@linux.dev> <20260903053535.17611-2-kaitao.cheng@linux.dev> To: Kaitao Cheng X-Mailer: Apple Mail (2.3864.700.51.1.1) > On Sep 3, 2026, at 13:35, Kaitao Cheng wrote: > > From: Kaitao Cheng > > Page flag helpers for configuration-dependent flags provide false or no-op > variants so that their users can be independent of the configuration. > > The HWPoison helpers do not fully follow this pattern. When > CONFIG_MEMORY_FAILURE is enabled, PAGEFLAG() and TESTSCFLAG() provide the > regular, test-and-set, and test-and-clear operations. When it is disabled, > only PAGEFLAG_FALSE() is instantiated, leaving TestSetPageHWPoison() and > TestClearPageHWPoison() undefined. > > Use TESTSCFLAG_FALSE() to provide the missing accessors when memory failure > handling is disabled. Both accessors return false, which is consistent with > HWPoison state being unavailable, and makes the accessor interface > consistent across configurations. > > Signed-off-by: Kaitao Cheng Acked-by: Muchun Song Thanks.