From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45DAC2F94AF for ; Fri, 4 Jul 2025 13:22:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751635359; cv=none; b=arN2M2bmOMx6q5ecvRM/0VslbmwSQRsosYNH6wA6CkSy3f4rYqZWC8YQoINcnsmei1qpaP00ZKZnyAH3y1JNpFw6IzDbgMad2JUdSn+n5BxmfL6zXKZ0yJp1+v9r0q2+mTu+MY6arAcPzomDzCLH8koMjTHJ+AJNov28o+pgZPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751635359; c=relaxed/simple; bh=NZwEDTKG16s4GLu3/3kVH1yKX1Wi2eX9GJGCc1Q3C0E=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=SwzlOCSHkvtF1d2JTvhnPRk+NSHeJyA3ZTGaEYVxRUzeVqEFi4r8DbC3ZBcfZSlRUbloO6wY3YTd/UJA+40QgjoTdsUWxle7K5xo8F+XecsKJgbuWN84Eu3LGuRPBOPIF/W5ejkzrTrnl9R8RnWjNqwObioRkcMPmV9sHSSEg/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hiI2k71V; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hiI2k71V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751635354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iS3p25tHU3RM4I/3CZVdnqBFJoVJz2HfsGdXG6RAfbg=; b=hiI2k71VdP/PqE3MxiONvkHnU0+rfs93fiYKbKx+eIYyxhWOLAfuHTztUGa6RglQM4AYER udbK2IfQVTCeQYdE0iKgUV8TzztDl2qRe6vIeRL/tsmyzDCr1sCnyeyp3XT1GYH7/epK7f I7e8X9EJeMzi4U6zv/P92yH1holaF20= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-woxzGjPOPhelzkNJjo_BxQ-1; Fri, 04 Jul 2025 09:22:32 -0400 X-MC-Unique: woxzGjPOPhelzkNJjo_BxQ-1 X-Mimecast-MFC-AGG-ID: woxzGjPOPhelzkNJjo_BxQ_1751635352 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a6d1394b07so581342f8f.3 for ; Fri, 04 Jul 2025 06:22:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751635351; x=1752240151; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iS3p25tHU3RM4I/3CZVdnqBFJoVJz2HfsGdXG6RAfbg=; b=TVcdKE4ePGZU0LiUwUg/7/CkrqSfMYGSBi06f+jBNdnLHZf5vraCJJaSc+caKxzcVp zz2NfgNwjQVbZpExTNMrDJMVxbJ5bnfVfael+2cnsw8A1mayHp8PMz1GNQGQe7HF4nlz E4EOtf8iq/JgPazzThqrVsGzyRBHw3ka8zI/zbW5Y0rTlxjXHp8ftuQT4qed/910AoT8 uoGuLMxCrRGxJMXzaJbsJn37w0u5dpsIAXKciQYfoK0jm2W4AV5/1+P73x603adjPk4p 20BYR1sr8WcXvTofnQyMxh6e5PNSi8xqMspvtGqsSdgIzOsvwrQMCJuEdoQNv0sX8Pj+ 1Wvw== X-Forwarded-Encrypted: i=1; AJvYcCVdUh/KoRjCyzyLPzEIktoXOhLAXzwIQjMw32UfO/jFSUOkydEfi/P0ttrOz4K2Xpbl5RiwSZw=@lists.linux.dev X-Gm-Message-State: AOJu0YzT0SbwQ+SeLbDDRzeY8EQeRqHwmQermA2sY4qmCAnq+MqXlE3b mIps21DqNt9mfrLshRrZrWJWNzeqzguQQLubQmZlrmoY4UmVmsR2giMdvoJfrUCfdm+HmcamoDI ISVjlwGb7nIafCJqmhCziQ5g08A1zsupHdXzqCFUQGPieP9ZVbgo8RyHLgA== X-Gm-Gg: ASbGnctSMyDm2n88OHvDgAcbCdwig/Vs97qURKr+Vbz+7oG9m7hKGN2rxWtn7EgV1Ia L6JkqtFk1sowlmeHVTjV/P7kfXzDnLPBXSCdb0IysfOpflMj5m8BpSOoyKTT7You5g00Cn+aKue c7QeMp2IuMemZFCHGZDlFTrRcBdINJ/HmDSH7uTqFclmiMYkNlHUC2vVnZjk2Qt365WwVxghLZX 8sS82ZE9RhFHhyM0bu7+yeQ1NFjtnZ0Q6mtDmM7pcHrTt63U+QhcMlcdEQSf9oXcu0gGvGigNI/ sD0rkckJUEe1EY3mJJSHyStrpIUSK8JRsDNk6Lvz5Q8eTijT4f+qRuEl/2fMX/eoWgckEJbI13i 7IrK81TWpsQ6ThbXQ388KOLVcAORtCMl0G4kOpSZBnjR5Ods= X-Received: by 2002:adf:eb4d:0:b0:3a4:f787:9b58 with SMTP id ffacd0b85a97d-3b496619e79mr1937386f8f.58.1751635351405; Fri, 04 Jul 2025 06:22:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHRARbbUWKXhwf/Qzsz+yNJbGOJQ/fx81Tbz4PDE6rtFVVnp8zr/goOYhsUspYRzJ16F+5PYA== X-Received: by 2002:adf:eb4d:0:b0:3a4:f787:9b58 with SMTP id ffacd0b85a97d-3b496619e79mr1937351f8f.58.1751635350955; Fri, 04 Jul 2025 06:22:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9bde954sm54847765e9.33.2025.07.04.06.22.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 06:22:30 -0700 (PDT) Message-ID: <36a8f286-1b09-43bd-9efa-5831ef3f315b@redhat.com> Date: Fri, 4 Jul 2025 15:22:28 +0200 Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 07/14] fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio From: David Hildenbrand To: Alistair Popple Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-8-david@redhat.com> <74acb38f-da34-448d-9b73-37433a5e342c@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <74acb38f-da34-448d-9b73-37433a5e342c@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BAM2lDl7ZGwUcuU3fUpw9wRdGulS_Df4GqdKdY2irAo_1751635352 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25.06.25 11:03, David Hildenbrand wrote: > On 24.06.25 03:16, Alistair Popple wrote: >> On Tue, Jun 17, 2025 at 05:43:38PM +0200, David Hildenbrand wrote: >>> Let's convert to vmf_insert_folio_pmd(). >>> >>> In the unlikely case there is already something mapped, we'll now still >>> call trace_dax_pmd_load_hole() and return VM_FAULT_NOPAGE. >>> >>> That should probably be fine, no need to add special cases for that. >> >> I'm not sure about that. Consider dax_iomap_pmd_fault() -> dax_fault_iter() -> >> dax_pmd_load_hole(). It calls split_huge_pmd() in response to VM_FAULT_FALLBACK >> which will no longer happen, what makes that ok? > > My reasoning was that this is the exact same behavior other > vmf_insert_folio_pmd() users here would result in. > > But let me dig into the details. Okay, trying to figure out what to do here. Assume dax_pmd_load_hole() is called and there is already something. We would have returned VM_FAULT_FALLBACK, now we would return VM_FAULT_NO_PAGE. That obviously only happens when we have not a write fault (otherwise, the shared zeropage does not apply). In dax_iomap_pmd_fault(), we would indeed split_huge_pmd(). In the DAX case (!anon vma), that would simply zap whatever is already mapped there. I guess we would then return VM_FAULT_FALLBACK from huge_fault-> ... -> dax_iomap_fault() and core MM code would fallback to handle_pte_fault() etc. and ... load a single PTE mapping the shared zeropage. BUT why is this case handled differently than everything else? E.g., (1) when we try inserting the shared zeropage through dax_load_hole()->vmf_insert_page_mkwrite() and there is already something ... we return VM_FAULT_NOPAGE. (2) when we try inserting a PTE mapping an ordinary folio through dax_fault_iter()->vmf_insert_page_mkwrite() and there is already something ... we return VM_FAULT_NOPAGE. (3) when we try inserting a PMD mapping an ordinary folio through dax_fault_iter()->vmf_insert_folio_pmd() and there is already something ... we return VM_FAULT_NOPAGE. So that makes me think ... the VM_FAULT_FALLBACK right now is probably ... wrong? And probably cannot be triggered? If there is already the huge zerofolio mapped, all good. Anything else is really not expected I would assume? -- Cheers, David / dhildenb