NVDIMM Device and Persistent Memory development
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Davidlohr Bueso <dave@stgolabs.net>, <vishal.l.verma@intel.com>
Cc: <nvdimm@lists.linux.dev>
Subject: Re: [ndctl PATCH] ndctl/security: fix Theory of Operation typos
Date: Tue, 25 Jul 2023 08:14:26 -0700	[thread overview]
Message-ID: <73ac6fc5-50ce-bde8-d77b-c28499b04436@intel.com> (raw)
In-Reply-To: <20230725015457.31084-1-dave@stgolabs.net>



On 7/24/23 18:54, Davidlohr Bueso wrote:
> Noticed while reading the file.
> 
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>

Thanks! Great catches.

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>   Documentation/ndctl/intel-nvdimm-security.txt | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/ndctl/intel-nvdimm-security.txt b/Documentation/ndctl/intel-nvdimm-security.txt
> index 88b305b81978..4ae7ed517279 100644
> --- a/Documentation/ndctl/intel-nvdimm-security.txt
> +++ b/Documentation/ndctl/intel-nvdimm-security.txt
> @@ -4,7 +4,7 @@ THEORY OF OPERATION
>   -------------------
>   The Intel Device Specific Methods (DSM) specification v1.7 and v1.8 [1]
>   introduced the following security management operations:
> -enable passhprase, update passphrase, unlock DIMM, disable security,
> +enable passphrase, update passphrase, unlock DIMM, disable security,
>   freeze security, secure (crypto) erase, overwrite, master passphrase
>   enable, master passphrase update, and master passphrase secure erase.
>   
> @@ -115,7 +115,7 @@ This is invoked using `--overwrite` option for ndctl 'sanitize-dimm'.
>   The overwrite operation wipes the entire NVDIMM. The operation can take a
>   significant amount of time. NOTE: When the command returns successfully,
>   it just means overwrite has been successfully started, and not that the
> -overwrite is complete. Subsequently, 'ndctl wait-overwrite'can be used
> +overwrite is complete. Subsequently, 'ndctl wait-overwrite' can be used
>   to wait for the NVDIMMs that are performing overwrite. Upon successful
>   completion of an overwrite, the WBINVD instruction is issued by the kernel.
>   If both --crypto-erase and --overwrite options are supplied, then

      reply	other threads:[~2023-07-25 15:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25  1:54 [ndctl PATCH] ndctl/security: fix Theory of Operation typos Davidlohr Bueso
2023-07-25 15:14 ` Dave Jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73ac6fc5-50ce-bde8-d77b-c28499b04436@intel.com \
    --to=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox