From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87D4D190673; Mon, 17 Jun 2024 10:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718620714; cv=none; b=kUfaDu8ARa9L3be/Y07aXkbITlzN07u5I/8lijrYnK/6FUit+IwOfow5/zOaPFzztfafzpm9bLGqp7i99mlGjwob2zbb5HZQTKMK0mw8zosxIZjTRKbFkpLoQivhqdUEq4m/+9UUOCnH9Npz4ulLvDdV3q+ujsKe8VF0QPudjzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718620714; c=relaxed/simple; bh=sLGpFpbuMerOCYp/S8r/v/Lw1PMCXDpInNufgD15eGo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WI9vGy/9sF0QEsp26cyIq7DecBjAsV7EcdhqcDbD0ELMS0tWpKKBYk6tfUh8Vo+pZnM7wjPc3obWiZqHppGg7VoCzUnfd4LY6UDWIIrK22CVKlKrShvxOXEDEGZJnvCgQ/B8+U4l8fn5avSdYHKB7nAxPb1l5e275UPyXPgR/v8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D55E65FCD9; Mon, 17 Jun 2024 10:38:29 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 337B2139AB; Mon, 17 Jun 2024 10:38:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WyrSCyUScGbNDAAAD6G6ig (envelope-from ); Mon, 17 Jun 2024 10:38:29 +0000 Message-ID: <74df67d6-3d02-4987-becb-eebf60492d26@suse.de> Date: Mon, 17 Jun 2024 12:38:28 +0200 Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 15/26] block: move the add_random flag to queue_limits To: Christoph Hellwig , Jens Axboe Cc: Geert Uytterhoeven , Richard Weinberger , Philipp Reisner , Lars Ellenberg , =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= , Josef Bacik , Ming Lei , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Vineeth Vijayan , "Martin K. Petersen" , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, Damien Le Moal References: <20240617060532.127975-1-hch@lst.de> <20240617060532.127975-16-hch@lst.de> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20240617060532.127975-16-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spam-Flag: NO X-Spam-Score: -4.00 X-Spam-Level: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: D55E65FCD9 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org On 6/17/24 08:04, Christoph Hellwig wrote: > Move the add_random flag into the queue_limits feature field so that it > can be set atomically with the queue frozen. > > Note that this also removes code from dm to clear the flag based on > the underlying devices, which can't be reached as dm devices will > always start out without the flag set. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal > --- > block/blk-mq-debugfs.c | 1 - > block/blk-sysfs.c | 6 +++--- > drivers/block/mtip32xx/mtip32xx.c | 1 - > drivers/md/dm-table.c | 18 ------------------ > drivers/mmc/core/queue.c | 2 -- > drivers/mtd/mtd_blkdevs.c | 3 --- > drivers/s390/block/scm_blk.c | 4 ---- > drivers/scsi/scsi_lib.c | 3 +-- > drivers/scsi/sd.c | 11 +++-------- > include/linux/blkdev.h | 5 +++-- > 10 files changed, 10 insertions(+), 44 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich