From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A2F9156E0 for ; Wed, 5 Jul 2023 23:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688601209; x=1720137209; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vfwj2TrdfZRsha2Ytu1/Llppjw/vL7dUZrBaGpysVdE=; b=fKDBaPGSxf1DylKnGNrifOtb4HX8XufRzt1PYxwrLHbTrDZB8FlazHoI gMxUhouT/0sNGt+Gcj4ROWwMq4/3tvBLJU815vl4ROIKudpIv4uCb3bCE w3vfA9BpdO67sxqXz+llg+F4Z6oyejWcjnJQHbdfQ5Kpbz9LkkLnYv+LF uOiIoUz4+pHt/wwCV7JSgBzXl3eJh9VIX1ZfEnqdXabT6m88ovwSJiW+r GukHRLsAQQJGDg8QjD3z8/762n5JS6odJ7pFHpCPvgY+buiIrUjuy/man m6RB9g2REKpwe5Qd1Tkh6Lqx+K++9oaR5S/L5jewuaAsnlQhUXd8iUeKx Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="360940572" X-IronPort-AV: E=Sophos;i="6.01,184,1684825200"; d="scan'208";a="360940572" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 16:53:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="843464546" X-IronPort-AV: E=Sophos;i="6.01,184,1684825200"; d="scan'208";a="843464546" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.209.61.134]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 16:53:27 -0700 Date: Wed, 5 Jul 2023 16:53:25 -0700 From: Alison Schofield To: Li Zhijian Cc: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, dave.jiang@intel.com Subject: Re: [ndctl PATCH v3 0/6] cxl/monitor and ndctl/monitor fixes Message-ID: References: <20230531021936.7366-1-lizhijian@fujitsu.com> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230531021936.7366-1-lizhijian@fujitsu.com> On Wed, May 31, 2023 at 10:19:30AM +0800, Li Zhijian wrote: > V3: > - update comit log of patch3 and patch6 per Dave's comments. > > V2: > - exchange order of previous patch1 and patch2 > - add reviewed tag in patch5 > - commit log improvements > > It mainly fix monitor not working when log file is specified. For > example > $ cxl monitor -l ./cxl-monitor.log > It seems that someone missed something at the begining. > > Furture, it compares the filename with reserved word more accurately > > patch1-2: It re-enables logfile(including default_log) functionality > and simplify the sanity check in the combination relative path file > and daemon mode. > > patch3 and patch6 change strncmp to strcmp to compare the acurrate > reserved words. > > Li Zhijian (6): > cxl/monitor: Enable default_log and refactor sanity check > cxl/monitor: replace monitor.log_file with monitor.ctx.log_file > cxl/monitor: use strcmp to compare the reserved word > cxl/monitor: always log started message > Documentation/cxl/cxl-monitor.txt: Fix inaccurate description > ndctl/monitor: use strcmp to compare the reserved word Hi, Patches 3 & 6 make the same change in 2 different files, with near identical commit logs. Please consider combining them into one patch, perhaps something like: ndctl: use strcmp for reserved word in monitor commands Thanks, Alison > > Documentation/cxl/cxl-monitor.txt | 3 +-- > cxl/monitor.c | 45 ++++++++++++++++--------------- > ndctl/monitor.c | 4 +-- > 3 files changed, 26 insertions(+), 26 deletions(-) > > -- > 2.29.2 >