From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68177200CE for ; Thu, 13 Jul 2023 20:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689280555; x=1720816555; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AK8EGyXuC8LhczGSHhQ5MxyAISKNC7yNcGgKWvZ4M0c=; b=KU4YHL5KRu8JVFJNcHo9ubJGFuHukSsaHnVg4rVuLJWJv5oIhFLk1D4q uvG9nRwIgNOvYjxqdRJeA5Cz0Zwx+WEygv6HDqf2R5nNyULAV8x2o+Vdn 61vduRTtHsbxId2rrDRrbS2wUFQfaqJN6AOkxlB+oaLNkxEnvHw3/x9qy 5fra+BbXuNbwGwnPGscoCfw51LzrDtN2bwf15dbs9hBZrmiA3q3uFw/4I Pctkv+rDXXeuaOyaFECYDzLeY0+sZpG6XeUxoB1gytbZkV98T5Nzc4165 Ddi0iyCJc5JDREIhVxk4LJsJ/EVTupz0qg4rXFdCyWOnqhWRTxeDcIHmt Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="362773220" X-IronPort-AV: E=Sophos;i="6.01,203,1684825200"; d="scan'208";a="362773220" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 13:35:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="725438653" X-IronPort-AV: E=Sophos;i="6.01,203,1684825200"; d="scan'208";a="725438653" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.212.243.201]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 13:35:53 -0700 Date: Thu, 13 Jul 2023 13:35:51 -0700 From: Alison Schofield To: Ben Dooks Cc: nvdimm@lists.linux.dev, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2] ACPI: NFIT: add helper to_nfit_mem() to take device to nfit_mem Message-ID: References: <20230712120810.21282-1-ben.dooks@codethink.co.uk> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230712120810.21282-1-ben.dooks@codethink.co.uk> On Wed, Jul 12, 2023 at 01:08:10PM +0100, Ben Dooks wrote: > Add a quick helper to just do struct device to the struct nfit_mem > field it should be referencing. This reduces the number of code > lines in some of the following code as it removes the intermediate > struct nvdimm. > > Signed-off-by: Ben Dooks Reviewed-by: Alison Schofield > --- > v2: > - fix typo of follwoing > - add blank line in to_nfit_mem() > --- > drivers/acpi/nfit/core.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index 0fcc247fdfac..b04c8a41380a 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -1361,18 +1361,23 @@ static const struct attribute_group *acpi_nfit_attribute_groups[] = { > NULL, > }; > > -static struct acpi_nfit_memory_map *to_nfit_memdev(struct device *dev) > +static struct nfit_mem *to_nfit_mem(struct device *dev) > { > struct nvdimm *nvdimm = to_nvdimm(dev); > - struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > + > + return nvdimm_provider_data(nvdimm); > +} > + > +static struct acpi_nfit_memory_map *to_nfit_memdev(struct device *dev) > +{ > + struct nfit_mem *nfit_mem = to_nfit_mem(dev); > > return __to_nfit_memdev(nfit_mem); > } > > static struct acpi_nfit_control_region *to_nfit_dcr(struct device *dev) > { > - struct nvdimm *nvdimm = to_nvdimm(dev); > - struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > + struct nfit_mem *nfit_mem = to_nfit_mem(dev); > > return nfit_mem->dcr; > } > @@ -1531,8 +1536,7 @@ static DEVICE_ATTR_RO(serial); > static ssize_t family_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > - struct nvdimm *nvdimm = to_nvdimm(dev); > - struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > + struct nfit_mem *nfit_mem = to_nfit_mem(dev); > > if (nfit_mem->family < 0) > return -ENXIO; > @@ -1543,8 +1547,7 @@ static DEVICE_ATTR_RO(family); > static ssize_t dsm_mask_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > - struct nvdimm *nvdimm = to_nvdimm(dev); > - struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > + struct nfit_mem *nfit_mem = to_nfit_mem(dev); > > if (nfit_mem->family < 0) > return -ENXIO; > @@ -1555,8 +1558,7 @@ static DEVICE_ATTR_RO(dsm_mask); > static ssize_t flags_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > - struct nvdimm *nvdimm = to_nvdimm(dev); > - struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > + struct nfit_mem *nfit_mem = to_nfit_mem(dev); > u16 flags = __to_nfit_memdev(nfit_mem)->flags; > > if (test_bit(NFIT_MEM_DIRTY, &nfit_mem->flags)) > @@ -1576,8 +1578,7 @@ static DEVICE_ATTR_RO(flags); > static ssize_t id_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > - struct nvdimm *nvdimm = to_nvdimm(dev); > - struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > + struct nfit_mem *nfit_mem = to_nfit_mem(dev); > > return sprintf(buf, "%s\n", nfit_mem->id); > } > @@ -1586,8 +1587,7 @@ static DEVICE_ATTR_RO(id); > static ssize_t dirty_shutdown_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > - struct nvdimm *nvdimm = to_nvdimm(dev); > - struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > + struct nfit_mem *nfit_mem = to_nfit_mem(dev); > > return sprintf(buf, "%d\n", nfit_mem->dirty_shutdown); > } > -- > 2.40.1 > >