Re: [ndctl PATCH v2 4/6] cxl/region: Add creation of Dynamic capacity regions

[Alison Schofield <alison.schofield@intel.com>]

On Mon, Nov 04, 2024 at 08:10:48PM -0600, Ira Weiny wrote:
> From: Navneet Singh <navneet.singh@intel.com>
> 
> CXL Dynamic Capacity Devices (DCDs) optionally support dynamic capacity
> with up to eight partitions (Regions) (dc0-dc7).  CXL regions can now be
> spare and defined as dynamic capacity (dc).
> 
> Add support for DCD devices.  Query for DCD capabilities.  Add the
> ability to add DC partitions to a CXL DC region.
> 
> Signed-off-by: Navneet Singh <navneet.singh@intel.com>
> Co-authored-by: Sushant1 Kumar <sushant1.kumar@intel.com>
> Signed-off-by: Sushant1 Kumar <sushant1.kumar@intel.com>
> Co-authored-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> ---
> Changes:
> [Fan: Properly initialize index]
> ---
>  cxl/json.c         | 26 +++++++++++++++
>  cxl/lib/libcxl.c   | 95 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  cxl/lib/libcxl.sym |  3 ++
>  cxl/lib/private.h  |  6 +++-
>  cxl/libcxl.h       | 55 +++++++++++++++++++++++++++++--

Hi Ira,

This is 'do as I say, not as I do' feedback, because I realize while
reviewing this, that I've been remiss in keeping the libcxl man page
updated.

Please document the new libcxl helpers here:
Documentation/cxl/lib/libcxl.txt  (it emits in 'man libcxl'

Sometimes it's just a quick add of the new helper. You can see what is
there and decide if additional verbage about DCD regions is needed.

Thanks and I'll do some catchup in that file after you ;)

-- Alison

snip