Re: [PATCH V3 18/20] cxl/pmem_region: Prep patch to accommodate pmem_region attributes

Neeraj Kumar
2025-11-13T07:50:05Z

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

On 12/11/25 08:40AM, Dave Jiang wrote:
>

<snip>

>> Keeping these functions in core/region.c (CONFIG_REGION)) and manually enabling CONFIG_LIBNVDIMM=y
>> will make it pass.
>>
>> Even if we can put these functions in core/region.c and forcefully make
>> libnvdimm (CONFIG_LIBNVDIMM) dependent using Kconfig. But I find it little improper as
>> this new dependency is not for all type of cxl devices (vmem and pmem) but only for cxl pmem
>> device region.
>>
>> Therefore I have seperated it out in core/pmem_region.c under Kconfig control
>> making libnvdimm forcefully enable if CONFIG_CXL_PMEM_REGION == y
>>
>> So, I believe this prep patch is required for this LSA 2.1 support.
>
>I think you misunderstood what I said. What I was trying to say is if possible to move all the diff changes of moving the existing code to a different place to a different patch. That way this patch is not full of those diff changes and make it easier to review.
>
>DJ

Hi Dave, Thanks for the clarification. Yes now I am able to get your point clear.

I should split this patch into two patches
1. First prep patch with no functionality change (Just code movement from core/region.c to newly core/pmem_region.c)
2. Second patch which calls the libnvdimm exported routines
- region_label_update_show/store()
- region_label_delete_store()

Regards,
Neeraj

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]