From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED79B28D8E9 for ; Fri, 20 Jun 2025 14:12:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750428767; cv=none; b=XIRS/lcE7qEgVqvQCzHkfy0K8jPMzlml8WZbB3E7rRtUomA9PiXftf2clKgcGC84r/4TJ6oqoDrLh/tSOFg3pGe6Rn4gGhMV+KAxByLxOkTy39NvezhwIdqZHf4F9TVMgdpGX4DTfEgPa7rnBeRylUNTrISt1nF9imMEs7PJotU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750428767; c=relaxed/simple; bh=qjM8Qrhoab/kYSa0GIn6YS+N8Y81lapvvHG2GTbpGo0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I1Qc7DhQDQy38EIH9W1w6olejEg6z8u2B6Incws3UzyxZIWN9xhUK1gwmqX5EGjNgLN+7cPALLZprOaGMPQ3wsatDfM5Vqv92nDGVWf0Rf9x2UxxINGeg7x4b0g9Vf/L+Cpr5FqlsxAdb5LCM5vw3WYWTo7qT/nCevru7Vmx7ZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=NWRV6aCQ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=lu5I6+IK; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=LITdzs1i; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=J8iZwDMK; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="NWRV6aCQ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="lu5I6+IK"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="LITdzs1i"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="J8iZwDMK" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 360232125C; Fri, 20 Jun 2025 14:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750428763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dtga4mO8TWdhcrNxuBweDXF4tRengQ+fG9VcYGmkW3c=; b=NWRV6aCQSbsSKVN5q7Y9eC89NBbMnvIGOdeD9jTgcLGeihP0m1+9IfJ5+hR6kw8yI9AAuZ 4eHDmJ8sPs3OVvqXplQVXS5djquRGXDNfQ7iWg/O4rcNRWFUZ+xyscmkQ90uwDPiNAr1zJ 22YmVELpFy1fhQpf3UtBY+9IODRAoiM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750428763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dtga4mO8TWdhcrNxuBweDXF4tRengQ+fG9VcYGmkW3c=; b=lu5I6+IKrQqOm4192LOXk9YZWP6wH/RZ0bgYxq9QyDcXuhYKm7+eejNbV+Z9D4qldbzsNu os4HkuacHmeJ9nCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750428762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dtga4mO8TWdhcrNxuBweDXF4tRengQ+fG9VcYGmkW3c=; b=LITdzs1igri+FwLqtM0ZNwDGXD4masM2omJHh/AYPLu9s73jc1wuAZXTdiEwma0v/YV3f0 UEXxFSYGjgJ6jG48+qTAN3LhSEcM2Go8CyS/rtXsOMcBx/uzgnW4/GlxLZ/4DEyUlxgz1F 2wgUcSTUnkFX8PS7NBCw7w5g76srinE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750428762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dtga4mO8TWdhcrNxuBweDXF4tRengQ+fG9VcYGmkW3c=; b=J8iZwDMKHqlx6VCsDIpTprxToxyIOpCO/tg1AQptUJ6i2mcjOOKEs+yuAuZPY2k3qr0FyG YECuaevK1f5TyxBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AB5C513736; Fri, 20 Jun 2025 14:12:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DZ8fJ1hsVWhhSAAAD6G6ig (envelope-from ); Fri, 20 Jun 2025 14:12:40 +0000 Date: Fri, 20 Jun 2025 16:12:35 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: Re: [PATCH RFC 04/14] mm/huge_memory: move more common code into insert_pmd() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-5-david@redhat.com> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250617154345.2494405-5-david@redhat.com> X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_TWELVE(0.00)[29]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLhwqoz3wsm4df3nfubx4grhps)]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,imap1.dmz-prg2.suse.org:helo] X-Spam-Level: X-Spam-Flag: NO X-Spam-Score: -4.30 On Tue, Jun 17, 2025 at 05:43:35PM +0200, David Hildenbrand wrote: > Let's clean it all further up. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador I was thinking maybe we want to pass 'struct vm_fault' directly to insert_pmd(), and retrieve the fields in there, but since you have to retrieve some in insert_pfn_pmd().. maybe not. -- Oscar Salvador SUSE Labs