From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2785252906 for ; Wed, 25 Jun 2025 09:22:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750843353; cv=none; b=C2sAhuMSWFyt1pnymlE5rA+R+nYSvW70p/mGNVa7rf/btg/5k4oy5yyeL1LOGKRHKmBQlEAl4kDqBfilsbgThWZHq/OswsP8FiHn2WpWWjNQvX/PaM6t0M8wV2xtNshRUXRmGGg4J47383NPxFaEO4H/eVwZwReHJSrPH6i5zN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750843353; c=relaxed/simple; bh=WFI6E6+VRUWyHl6ZReIPA0IZvlzEs7H4ajbL8lgEN5E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fYmfCzOKMxNIQPfinjogKWBqI+GZ/KxlRz6Fbc6OTbclWhfE7h3wYDOJrCas3++2fYbfWhPSWimlrlfYoqr96Fl/xsis7FLOmclARwp6QihpdAfkv2/pkU/G8u/GisBMrMzlXbCAmqgG4CDE2KpDCBEzGWeHaOuEdkkfKonq/fA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rbtjJP9z; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=GgVMoCJy; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=O/vvHBWM; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=xfzFyc8T; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rbtjJP9z"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="GgVMoCJy"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="O/vvHBWM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="xfzFyc8T" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CC8941F441; Wed, 25 Jun 2025 09:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750843349; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PkNXozaFqCl3r1OmdA8t+IzKcrfCQu04Mbq/ObVKxp8=; b=rbtjJP9zhGrVoJ43Ic9kugFSgL+KJpHkhNFjNzwFABe+2xjA8xtzPucLEDHFiRnRsWrdwn gsoOiPJig/Yv0UcdGA1Nce3zenDSyru5GjEROLMekd/5/3GvIDBP1sl3ABsroWeWdJ30X0 Egm+gOPeA6Oq9ou2STYzXGu8ISNcZF4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750843349; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PkNXozaFqCl3r1OmdA8t+IzKcrfCQu04Mbq/ObVKxp8=; b=GgVMoCJyBt986jshsNs+3JcbCpxXSTveGpp2fw/56tFaD4umjtQPTNQmwnmEUrXGcdYk/c Q8lfEQQpRSTJyyCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="O/vvHBWM"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xfzFyc8T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750843348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PkNXozaFqCl3r1OmdA8t+IzKcrfCQu04Mbq/ObVKxp8=; b=O/vvHBWMUGSXvYo9OiVppR/pJSlJIxUObpuvSRpSaq2f4LaAbtBS3GI/sWSYARt0fzWuSg phQeflOpg4l1YLtUYYNw9Y1ctszd/PXb6vCfCv2Zu845RlwSlnNYMhul/Othun4kVSc6k+ sk3WDOpHEsJ3jKgJ66p7kU/LAAFF3YE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750843348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PkNXozaFqCl3r1OmdA8t+IzKcrfCQu04Mbq/ObVKxp8=; b=xfzFyc8TfzuRj1e5fLLi2HFfMPWUNAuYgqbpY6DE84k35H3GMtTOQQ3rrTI7xZXm5gaGhn soUCykV8MVeapKBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5E66713485; Wed, 25 Jun 2025 09:22:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id t8dVFNO/W2gdMQAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 09:22:27 +0000 Date: Wed, 25 Jun 2025 11:22:25 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: Re: [PATCH RFC 13/14] mm: introduce and use vm_normal_page_pud() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-14-david@redhat.com> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250617154345.2494405-14-david@redhat.com> X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: CC8941F441 X-Rspamd-Action: no action X-Spam-Flag: NO X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_TWELVE(0.00)[29]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RL88oxspsx4bg3gu1yybyqiqt4)]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,localhost.localdomain:mid] X-Spam-Score: -4.51 X-Spam-Level: On Tue, Jun 17, 2025 at 05:43:44PM +0200, David Hildenbrand wrote: > Let's introduce vm_normal_page_pud(), which ends up being fairly simple > because of our new common helpers and there not being a PUD-sized zero > folio. > > Use vm_normal_page_pud() in folio_walk_start() to resolve a TODO, > structuring the code like the other (pmd/pte) cases. Defer > introducing vm_normal_folio_pud() until really used. > > Signed-off-by: David Hildenbrand Ignoring the parameter stuff, I'd make the same comment I made wrt. vm_normal_page_pmd, but LGTM. Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs