Re: [ndctl PATCH v3] cxl/list: remove libtracefs build dependency for --media-errors

[Alison Schofield <alison.schofield@intel.com>]

On Thu, Sep 25, 2025 at 08:55:50AM -0700, Dan Williams wrote:
> Alison Schofield wrote:
> > When the --media-errors option was added to cxl list it inadvertently
> > changed the optional libtracefs requirement into a mandatory one.
> > Ndctl versions 80,81,82 no longer build without libtracefs.
> > 
> > Remove that dependency.
> > 
> > When libtracefs is disabled the user will see a this message logged
> > to stderr:
> > 	$ cxl list -r region0 --media-errors --targets
> > 	cxl list: --media-errors support disabled at build time
> > 
> > ...followed by the region listing including the output for any other
> > valid command line options, like --targets in the example above.
> > 
> > When libtracefs is disabled the cxl-poison.sh unit test is omitted.
> > 
> > The man page gets a note:
> > 	The media-error option is only available with -Dlibtracefs=enabled.
> > 
> > Reported-by: Andreas Hasenack <andreas.hasenack@canonical.com>
> > Fixes: d7532bb049e0 ("cxl/list: add --media-errors option to cxl list")
> > Closes: https://github.com/pmem/ndctl/issues/289
> > Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
> > Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> > Link: https://lore.kernel.org/r/20250924045302.90074-1-alison.schofield@intel.com
> > Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> > ---
> > 
> > Changes in v3:
> > - Remove ifdef's from .c files (Dan)
> >   Move ifdef chunk in json.c to a new conditionally compiled json_poison.c.
> >   Move ifdef notice message to !ENABLE_LIBTRACEFS stub in event_trace.h.
> 
> Looks great, I appreciate the ifdef reorganization effort.
> 
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>

Thanks for the review!
Pending rebased with this v3 version:
https://github.com/pmem/ndctl/commit/b26e9ae