From: Alison Schofield <alison.schofield@intel.com>
To: Marc Herbert <marc.herbert@linux.intel.com>
Cc: <nvdimm@lists.linux.dev>, <linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH v3] cxl: Add cxl-translate.sh unit test
Date: Sun, 9 Nov 2025 17:46:34 -0800 [thread overview]
Message-ID: <aRFD-iJbAxz10aS_@aschofie-mobl2.lan> (raw)
In-Reply-To: <m2bjlhtd27.fsf@C02X38VBJHD2mac.jf.intel.com>
On Tue, Nov 04, 2025 at 06:42:40PM -0800, Marc Herbert wrote:
Marc,
Thanks for the review. I applied all your suggestions in v4.
>
> > [ 'cxl-qos-class.sh', cxl_qos_class, 'cxl' ],
> > [ 'cxl-poison.sh', cxl_poison, 'cxl' ],
> > + [ 'cxl-translate.sh', cxl_translate, 'cxl' ],
> > ]
>
> Just FYI: this now conflicts with b26e9ae3b1dc. I got very confused
> because I was missing a commit and kept looking for the correct
> "pending" branch when in fact it's v3 missing a commit, not me.
> Also, I forgot how clueless "git am" is. Even "patch" is better.
>
Sorry for not including a base-commit in that patch.
> These lists are a regular source of conflicts when all the activity
> always happens at the end. Defining some sort of order (alphabetical or
> whatever) reduces the frequency of conflicts considerably.
I've started mulling this over. Alphabetical caught my attention
because as our list of tests grows :) :) :) scanning the results
in order appeals to me. The part that is not so obvious is that the
execution list is not built strictly from one list. And, off course,
when there is a conflict because more than one test was recently added,
it's usually a simple and nice conflict to resolve.
prev parent reply other threads:[~2025-11-10 1:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 0:34 [ndctl PATCH v3] cxl: Add cxl-translate.sh unit test Alison Schofield
2025-11-04 23:25 ` Dave Jiang
2025-11-05 2:42 ` Marc Herbert
2025-11-10 1:46 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRFD-iJbAxz10aS_@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=marc.herbert@linux.intel.com \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox