Re: [PATCH v1 1/1] libnvdimm/labels: Get rid of redundant 'else'

Alison Schofield
2025-11-09T22:12:06Z

On Fri, Nov 07, 2025 at 10:23:32AM -0600, Ira Weiny wrote:
>
> Yea putting this in the commit message but more importantly knowing you
> looked through the logic of how claim class is used is what I'm looking
> for.
>
> Thanks,
> Ira
>

Hi Ira,

Coming back around to this patch after a few days, after initially
commenting on the unexplained behavior change, I realize a better
response would have been a simple NAK.

This patch demonstrates why style-only cleanups are generally discouraged
outside of drivers/staging. It creates code churn without fixing bugs
or adding functionality, the changes aren't justified in the commit
message, it adds risk, and consumes limited reviewer and maintainer
bandwidth.

To recoup value from the time already spent on this, I suggest using
this opportunity to set a clear position and precedent, like:

"Style cleanups are not welcomed in the NVDIMM subsystem unless
they're part of a fix or a patch series that includes substantive
changes to the same code area."

FWIW, if folks are looking to dive into this code, there is a patchset
in review here[1] that adds new functionality to this area. Reviews,
including style reviews, are welcomed.

Regardless of a commit message update or a change to the code, this
one is a NAK from me.

--Alison

[1] https://lore.kernel.org/nvdimm/20250917132940.1566437-1-s.neeraj@samsung.com/