From: Christoph Hellwig <hch@infradead.org>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: Jens Axboe <axboe@kernel.dk>,
drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-block@vger.kernel.org,
Joel Colledge <joel.colledge@linbit.com>,
an Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
nvdimm@lists.linux.dev
Subject: Re: [PATCH 08/20] drbd: add DAX/PMEM support for metadata access
Date: Tue, 7 Apr 2026 22:46:26 -0700 [thread overview]
Message-ID: <adXrslkhromDtu37@infradead.org> (raw)
In-Reply-To: <20260327223820.2244227-9-christoph.boehmwalder@linbit.com>
Adding the dax maintainers and they really need to review this.
> + long want = (drbd_md_last_sector(bdev) + 1 - first_sector) >> (PAGE_SHIFT - SECTOR_SHIFT);
> + pgoff_t pgoff = first_sector >> (PAGE_SHIFT - SECTOR_SHIFT);
> + long md_offset_byte = (bdev->md.md_offset - first_sector) << SECTOR_SHIFT;
> + long al_offset_byte = (al_sector - first_sector) << SECTOR_SHIFT;
You really want helpers to make all these unit conversions maintainable.
parent reply other threads:[~2026-04-08 5:46 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260327223820.2244227-9-christoph.boehmwalder@linbit.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adXrslkhromDtu37@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=drbd-dev@lists.linbit.com \
--cc=joel.colledge@linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=philipp.reisner@linbit.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox