From: Shivaprasad G Bhat <sbhat@linux.ibm.com>
To: Santosh Sivaraj <santosh@fossix.org>,
Dan Williams <dan.j.williams@intel.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
enozhatsky@chromium.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
willy@infradead.org, Dave Hansen <dave.hansen@linux.intel.com>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
Vaibhav Jain <vaibhav@linux.ibm.com>
Subject: Re: [PATCH v4 26/34] tools/testing/nvdimm: Convert to printbuf
Date: Fri, 1 Jul 2022 12:02:51 +0530 [thread overview]
Message-ID: <b299ebe2-88e5-c2bd-bad0-bef62d4acdfe@linux.ibm.com> (raw)
In-Reply-To: <CA+n8AA-grcDuYWt-TxcttK+2tHpEP4s9ue2uq_0d8=hJpqNh+g@mail.gmail.com>
On 6/25/22 05:12, Santosh Sivaraj wrote:
> I don't have setup to test this now. Adding Shiva and Vaibhav who could
> probably help. Thanks, Santosh On Sat, 25 Jun, 2022, 1:03 am Dan
> Williams, <dan.j.williams@intel.com> wrote: [ add Santosh ] Kent
> Overstreet wrote:
> ZjQcmQRYFpfptBannerStart
> This Message Is From an External Sender
> This message came from outside your organization.
> ZjQcmQRYFpfptBannerEnd
> I don't have setup to test this now. Adding Shiva and Vaibhav who could
> probably help.
>
> Thanks,
> Santosh
>
> On Sat, 25 Jun, 2022, 1:03 am Dan Williams, <dan.j.williams@intel.com
> <mailto:dan.j.williams@intel.com>> wrote:
>
> [ add Santosh ]
>
> Kent Overstreet wrote:
> > This converts from seq_buf to printbuf. Here we're using printbuf
> with
> > an external buffer, meaning it's a direct conversion.
> >
> > Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com
> <mailto:kent.overstreet@gmail.com>>
> > Cc: Dan Williams <dan.j.williams@intel.com
> <mailto:dan.j.williams@intel.com>>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com
> <mailto:dave.hansen@linux.intel.com>>
> > Cc: nvdimm@lists.linux.dev <mailto:nvdimm@lists.linux.dev>
>
> Acked-by: Dan Williams <dan.j.williams@intel.com
> <mailto:dan.j.williams@intel.com>>
>
The ndtest build requires [1] as the build is currently broken from
nd_namespace_blk/blk_region infrastructure removal.
Dan, Could you review [1] and see if it can be included as well ?
With [1], the this patch is tested, and works fine.
Tested-By: Shivaprasad G Bhat <sbhat@linux.ibm.com>
References:
[1]
https://patchwork.kernel.org/project/linux-nvdimm/patch/165025395730.2821159.14794984437851867426.stgit@lep8c.aus.stglabs.ibm.com/
> This probably also wants a Tested-by from Santosh, but it looks ok
> to me.
>
prev parent reply other threads:[~2022-07-01 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220620004233.3805-1-kent.overstreet@gmail.com>
2022-06-20 0:42 ` [PATCH v4 26/34] tools/testing/nvdimm: Convert to printbuf Kent Overstreet
2022-06-24 19:32 ` Dan Williams
[not found] ` <CA+n8AA-grcDuYWt-TxcttK+2tHpEP4s9ue2uq_0d8=hJpqNh+g@mail.gmail.com>
2022-07-01 6:32 ` Shivaprasad G Bhat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b299ebe2-88e5-c2bd-bad0-bef62d4acdfe@linux.ibm.com \
--to=sbhat@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=enozhatsky@chromium.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=nvdimm@lists.linux.dev \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=santosh@fossix.org \
--cc=vaibhav@linux.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox