Re: [PATCH] xfs: drop experimental warning for FSDAX

[Shiyang Ruan <ruansy.fnst@fujitsu.com>]

在 2023/10/5 8:08, Darrick J. Wong 写道:
>>>
>>> Sorry, I sent the list below to Chandan, didn't cc the maillist
>>> because it's just a rough list rather than a PR:
>>>
>>>
>>> 1. subject: [v3]  xfs: correct calculation for agend and blockcount
>>>     url:
>>>     https://lore.kernel.org/linux-xfs/20230913102942.601271-1-ruansy.fnst@fujitsu.com/
>>>     note:    This one is a fix patch for commit: 5cf32f63b0f4 ("xfs:
>>>     fix the calculation for "end" and "length"").
>>>              It can solve the fail of xfs/55[0-2]: the programs
>>>              accessing the DAX file may not be notified as expected,
>>>             because the length always 1 block less than actual.  Then
>>>            this patch fixes this.
>>>
>>>
>>> 2. subject: [v15] mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind
>>>     url:
>>>     https://lore.kernel.org/linux-xfs/20230928103227.250550-1-ruansy.fnst@fujitsu.com/T/#u
>>>     note:    This is a feature patch.  It handles the pre-remove event
>>>     of DAX device, by notifying kernel/user space before actually
>>>    removing.
>>>              It has been picked by Andrew in his
>>>              mm-hotfixes-unstable. I am not sure whether you or he will
>>>             merge this one.
>>>
>>>
>>> 3. subject: [v1]  xfs: drop experimental warning for FSDAX
>>>     url:
>>>     https://lore.kernel.org/linux-xfs/20230915063854.1784918-1-ruansy.fnst@fujitsu.com/
>>>     note:    With the patches mentioned above, I did a lot of tests,
>>>     including xfstests and blackbox tests, the FSDAX function looks
>>>    good now.  So I think the experimental warning could be dropped.
>>
>> Darrick/Dave, Could you please review the above patch and let us know if you
>> have any objections?
> 
> The first two patches are ok.  The third one ... well I was about to say
> ok but then this happened with generic/269 on a 6.6-rc4 kernel and those
> two patches applied:

Hi Darrick,

Thanks for testing.  I just tested this case (generic/269) on v6.6-rc4 
with my 3 patches again, but it didn't fail.  Such WARNING message 
didn't show in dmesg too.

My local.config is shown as below:
[nodax_reflink]
export FSTYP=xfs
export TEST_DEV=/dev/pmem0
export TEST_DIR=/mnt/test
export SCRATCH_DEV=/dev/pmem1
export SCRATCH_MNT=/mnt/scratch
export MKFS_OPTIONS="-m reflink=1,rmapbt=1"

[dax_reflink]
export FSTYP=xfs
export TEST_DEV=/dev/pmem0
export TEST_DIR=/mnt/test
export SCRATCH_DEV=/dev/pmem1
export SCRATCH_MNT=/mnt/scratch
export MKFS_OPTIONS="-m reflink=1,rmapbt=1"
export MOUNT_OPTIONS="-o dax"
export TEST_FS_MOUNT_OPTS="-o dax"

And tools version are:
  - xfstests (v2023.09.03)
  - xfsprogs (v6.4.0)


Could you show me more info (such as kernel config, local.config) ?  So 
that I can find out what exactly is going wrong.


--
Thanks,
Ruan.