ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 10/18] ocfs2: Use dlm_print_one_lock_resource for lock resource print
Date: Tue Mar 11 16:32:22 2008	[thread overview]
Message-ID: <1205278329-11111-11-git-send-email-sunil.mushran@oracle.com> (raw)
In-Reply-To: <1205278329-11111-1-git-send-email-sunil.mushran@oracle.com>

Mainline commit 2af37ce82d199d1d8cd6286f42f37d321627a807
Author: Tao Ma <tao.ma@oracle.com>
Date: Thu, 28 Feb 2008 10:41:55 +0800

__dlm_print_one_lock_resource must be called with spin_lock
the res->spinlock. While in some cases, we use it without this
precondition and lead to the failure of assert_spin_locked.
So call dlm_print_one_lock_resource instead.

Signed-off-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
---
 fs/ocfs2/dlm/dlmconvert.c  |    2 +-
 fs/ocfs2/dlm/dlmmaster.c   |    4 ++--
 fs/ocfs2/dlm/dlmrecovery.c |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/ocfs2/dlm/dlmconvert.c b/fs/ocfs2/dlm/dlmconvert.c
index ecb4d99..75997b4 100644
--- a/fs/ocfs2/dlm/dlmconvert.c
+++ b/fs/ocfs2/dlm/dlmconvert.c
@@ -487,7 +487,7 @@ int dlm_convert_lock_handler(struct o2net_msg *msg, u32 len, void *data,
 			       "cookie=%u:%llu\n",
 		     dlm_get_lock_cookie_node(be64_to_cpu(cnv->cookie)),
 		     dlm_get_lock_cookie_seq(be64_to_cpu(cnv->cookie)));
-		__dlm_print_one_lock_resource(res);
+		dlm_print_one_lock_resource(res);
 		goto leave;
 	}
 
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
index da627c8..5b27581 100644
--- a/fs/ocfs2/dlm/dlmmaster.c
+++ b/fs/ocfs2/dlm/dlmmaster.c
@@ -2348,7 +2348,7 @@ int dlm_deref_lockres_handler(struct o2net_msg *msg, u32 len, void *data,
 			mlog(ML_ERROR, "%s:%.*s: node %u trying to drop ref "
 		     	"but it is already dropped!\n", dlm->name,
 		     	res->lockname.len, res->lockname.name, node);
-			__dlm_print_one_lock_resource(res);
+			dlm_print_one_lock_resource(res);
 		}
 		ret = 0;
 		goto done;
@@ -2408,7 +2408,7 @@ static void dlm_deref_lockres_worker(struct dlm_work_item *item, void *data)
 		mlog(ML_ERROR, "%s:%.*s: node %u trying to drop ref "
 		     "but it is already dropped!\n", dlm->name,
 		     res->lockname.len, res->lockname.name, node);
-		__dlm_print_one_lock_resource(res);
+		dlm_print_one_lock_resource(res);
 	}
 
 	dlm_lockres_put(res);
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
index 796fb73..3004f95 100644
--- a/fs/ocfs2/dlm/dlmrecovery.c
+++ b/fs/ocfs2/dlm/dlmrecovery.c
@@ -1191,7 +1191,7 @@ static int dlm_add_lock_to_array(struct dlm_lock *lock,
 			    (ml->type == LKM_EXMODE ||
 			     memcmp(mres->lvb, lock->lksb->lvb, DLM_LVB_LEN))) {
 				mlog(ML_ERROR, "mismatched lvbs!\n");
-				__dlm_print_one_lock_resource(lock->lockres);
+				dlm_print_one_lock_resource(lock->lockres);
 				BUG();
 			}
 			memcpy(mres->lvb, lock->lksb->lvb, DLM_LVB_LEN);
-- 
1.5.3.4

  parent reply	other threads:[~2008-03-11 16:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11 16:32 [Ocfs2-devel] Backports to OCFS2 1.4 Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 07/18] ocfs2: make dlm_do_assert_master() static Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 08/18] ocfs2: Correct use of ! and & in aops.c Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 01/18] ocfs2: Add helper task_pid_nr Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 05/18] ocfs2: possible cleanups Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 06/18] ocfs2: make ocfs2_downconvert_thread() static Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 04/18] ocfs2: Fix writeout in ocfs2_data_convert_worker() Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 02/18] ocfs2: Spelling fixes Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 14/18] ocfs2/dlm: Add missing dlm_lockres_put()s in migration path Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 11/18] ocfs2: Fix endian bug in o2dlm protocol negotiation Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 15/18] ocfs2/dlm: Add missing dlm_lockres_put()s Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 16/18] ocfs2/dlm: Print message showing the recovery master Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 03/18] ocfs2: Negotiate locking protocol versions Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 12/18] ocfs2: Fix an endian bug in online resize Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 09/18] ocfs2/dlm: fix printk warning Sunil Mushran
2008-03-11 16:32 ` Sunil Mushran [this message]
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 18/18] ocfs2: Fix NULL pointer dereferences in o2net Sunil Mushran
2008-03-16 21:10   ` [Ocfs2-devel] how to use run_lvb_torture.py ? Coly Li
2008-03-17  5:09     ` Marcos E. Matsunaga
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 17/18] ocfs2/dlm: dlm_thread should not sleep while holding the dlm_spinlock Sunil Mushran
2008-03-11 16:32 ` [Ocfs2-devel] [PATCH 13/18] ocfs2/dlm: Add missing dlm_lock_put()s Sunil Mushran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205278329-11111-11-git-send-email-sunil.mushran@oracle.com \
    --to=sunil.mushran@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).