From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 2/2] ocfs2: Add cluster lock stats at the fs level
Date: Mon, 12 May 2008 18:06:04 -0700 [thread overview]
Message-ID: <20080513010604.GH12100@mail.oracle.com> (raw)
In-Reply-To: <20080513004255.GF25156@wotan.suse.de>
On Mon, May 12, 2008 at 05:42:55PM -0700, Mark Fasheh wrote:
> On Thu, May 08, 2008 at 10:57:01AM -0700, Sunil Mushran wrote:
>
> > @@ -2461,7 +2531,11 @@ static void *ocfs2_dlm_seq_next(struct seq_file *m, void *v, loff_t *pos)
> > }
> >
> > /* So that debugfs.ocfs2 can determine which format is being used */
> > +#ifdef CONFIG_OCFS2_FS_STATS
> > +#define OCFS2_DLM_DEBUG_STR_VERSION 2
> > +#else
> > #define OCFS2_DLM_DEBUG_STR_VERSION 1
> > +#endif
>
> Why not just bump this and print zero's if CONFIG_OCFS2_FS_STATS isn't
> enabled?
I second this.
Joel
--
"In a crisis, don't hide behind anything or anybody. They're going
to find you anyway."
- Paul "Bear" Bryant
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-05-13 1:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 17:57 [Ocfs2-devel] [PATCH 1/2] ocfs2: Add OCFS2_FS_STATS config option Sunil Mushran
2008-05-08 17:57 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: Add cluster lock stats at the fs level Sunil Mushran
2008-05-13 0:42 ` Mark Fasheh
2008-05-13 1:06 ` Joel Becker [this message]
2008-05-13 0:42 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: Add OCFS2_FS_STATS config option Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513010604.GH12100@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).