From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Date: Thu, 22 Apr 2010 03:18:56 -0700 Subject: [Ocfs2-devel] [PATCH 1/2] Ocfs2: Add macro OCFS2_VOL_UUIDSTR_LEN in ocfs2_fs.h In-Reply-To: <4BCF44C5.6050701@oracle.com> References: <1271746743-17653-1-git-send-email-tristan.ye@oracle.com> <20100420223223.GB9423@mail.oracle.com> <4BCE2C03.5000506@oracle.com> <4BCE2F29.3060104@oracle.com> <4BCE5792.8010104@oracle.com> <4BCF44C5.6050701@oracle.com> Message-ID: <20100422101855.GB23419@mail.oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com On Wed, Apr 21, 2010 at 11:32:37AM -0700, Sunil Mushran wrote: > tristan wrote: > > Sunil Mushran wrote: > >> ok. So how about we remove this #define totally and have > >> the ioctl interface return the binary uuid. The o2info tool > >> can convert do the conversion. > > > > But... returning binary uuid from o2info was not that easy, ocfs2 > > in-memory super_block osb only successfully initialized the osb->uuid, > > while did nothing to uuid_str, I remembered we've been discussing on > > that issue: > > > > http://oss.oracle.com/pipermail/ocfs2-devel/2009-November/005514.html > > > > > > That patch was not adopted, and we're still using uuid_str in most > > places. > > Ok. Thanks for reminding me. > > It appears we already have OCFS2_TEXT_UUID_LEN in stack_user.c. That's a > clean name. In the patch below, I have moved it to ocfs2.h so that we can > use it elsewhere. > > http://oss.oracle.com/~smushran/0001-ocfs2-Cleanup-uuid-strings.patch > > I am waiting for Joel to comment. If he approves, then you can use the > same #define in your ioctl. I'm glad you like the name, and I'm fine with you adding it to ocfs2.h, but it should not be removing the define from stack_user.c. Note that stack_user.c does not include ocfs2.h. Joel -- "Any man who is under 30, and is not a liberal, has not heart; and any man who is over 30, and is not a conservative, has no brains." - Sir Winston Churchill Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127