From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Date: Fri, 23 Apr 2010 13:50:37 -0700 Subject: [Ocfs2-devel] ocfs2: question about dlmfs_file_read() In-Reply-To: <20100418193201.GD7920@bicker> References: <20100418193201.GD7920@bicker> Message-ID: <20100423205037.GC10637@mail.oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com On Sun, Apr 18, 2010 at 10:32:01PM +0300, Dan Carpenter wrote: > Hello list, > > I was looking through the code for something unrelated and I got > confused by this. > > fs/ocfs2/dlmfs/dlmfs.c dlmfs_file_read() > 261 /* don't read past the lvb */ > 262 if ((count + *ppos) > i_size_read(inode)) > 263 readlen = i_size_read(inode) - *ppos; > 264 else > 265 readlen = count - *ppos; > > Shouldn't "readlen" just be "count" here? What prevents it from > being a negative number? > > 266 > 267 lvb_buf = kmalloc(readlen, GFP_NOFS); > > Anyway, this code has been around for a long time so I'm probably > missing something. I was just curious. No, I think you're right. Mark, Sunil, anyone? Joel -- Life's Little Instruction Book #510 "Count your blessings." Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127