From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/xattr: Reset xattr value size in cleanup_truncate.
Date: Fri, 7 May 2010 14:09:33 -0700 [thread overview]
Message-ID: <20100507210933.GA27987@mail.oracle.com> (raw)
In-Reply-To: <1273213054-1672-1-git-send-email-tao.ma@oracle.com>
On Fri, May 07, 2010 at 02:17:34PM +0800, Tao Ma wrote:
> So this patch try to resolve it by adding the original_value_size to
> ocfs2_xa_cleanup_value_truncate and let it handle it. So xe_value_size
> will only be reset in case we want to reserve the xe entry. There is
> also a side effect that we can remove the fat comment before we set
> the xe_value_size in ocfs2_xa_prepare_entry.
Still NAK. There's no need for cleanup_value_truncate() to know
about this.
Joel
--
"When arrows don't penetrate, see...
Cupid grabs the pistol."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
prev parent reply other threads:[~2010-05-07 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 6:17 [Ocfs2-devel] [PATCH] ocfs2/xattr: Reset xattr value size in cleanup_truncate Tao Ma
2010-05-07 21:09 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100507210933.GA27987@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).