ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Wengang Wang <wen.gang.wang@ORACLE.COM>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master
Date: Tue, 8 Jun 2010 20:49:21 +0800	[thread overview]
Message-ID: <20100608124921.GA3964@laptop.us.oracle.com> (raw)
In-Reply-To: <4C0851AF.1030803@oracle.com>

On 10-06-03 18:06, Srinivas Eeda wrote:
> Comments inline
> 
> On 6/3/2010 9:37 AM, Wengang Wang wrote:
> >Changes to V1:
> >1 move the msleep to the second runs when the lockres is in recovery so the
> >  purging work on other lockres' can go.
> >2 do not inform recovery master if DLM_LOCK_RES_DROPPING_REF is set and don't
> >  resend deref in this case.
> >
> >Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> >---
> > fs/ocfs2/dlm/dlmcommon.h   |    1 +
> > fs/ocfs2/dlm/dlmrecovery.c |   25 +++++++++++++++
> > fs/ocfs2/dlm/dlmthread.c   |   73 ++++++++++++++++++++++++++++++++++++++-----
> > 3 files changed, 90 insertions(+), 9 deletions(-)
> >
> >diff --git a/fs/ocfs2/dlm/dlmcommon.h b/fs/ocfs2/dlm/dlmcommon.h
> >index 4b6ae2c..4194087 100644
> >--- a/fs/ocfs2/dlm/dlmcommon.h
> >+++ b/fs/ocfs2/dlm/dlmcommon.h
> >@@ -280,6 +280,7 @@ static inline void __dlm_set_joining_node(struct dlm_ctxt *dlm,
> > #define DLM_LOCK_RES_IN_PROGRESS          0x00000010
> > #define DLM_LOCK_RES_MIGRATING            0x00000020
> > #define DLM_LOCK_RES_DROPPING_REF         0x00000040
> >+#define DLM_LOCK_RES_DE_DROP_REF          0x00000080
> Can you please explain the idea of the new flag DLM_LOCK_RES_DE_DROP_REF :)
> 

Discussed with Srini privately, both agreed we don't purge a lockres
when it's in recovery state avoiding adding the new flag.

I will send the revised patch later.

regards,
wengang.

  parent reply	other threads:[~2010-06-08 12:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04  1:06 [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master Srinivas Eeda
2010-06-04  1:43 ` Wengang Wang
2010-06-04  2:17   ` Srinivas Eeda
2010-06-04  5:37     ` Wengang Wang
2010-06-06  1:48       ` Srinivas Eeda
2010-06-08 12:49 ` Wengang Wang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-05-25  4:54 [Ocfs2-devel] [PATCH 1/1] ocfs2/dlm: resend deref to new master if recovery occures Srinivas Eeda
2010-06-03 16:37 ` [Ocfs2-devel] [PATCH] ocfs2/dlm: cancel the migration or redo deref to recovery master Wengang Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100608124921.GA3964@laptop.us.oracle.com \
    --to=wen.gang.wang@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).