ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 4/4] ocfs2: make mmap CoW work with readahead.
Date: Tue, 29 Jun 2010 16:24:23 -0700	[thread overview]
Message-ID: <20100629232423.GJ4150@mail.oracle.com> (raw)
In-Reply-To: <1277800541-6844-4-git-send-email-tao.ma@oracle.com>

On Tue, Jun 29, 2010 at 04:35:41PM +0800, Tao Ma wrote:
> refcount_cow need file * to do the readahead.
> So we just add 'struct file *' to ocfs2_write_begin_nolock
> and __ocfs2_page_mkwrite and let them pass this parameter
> to ocfs2_refcount_cow.

	As I stated in my comment on the first patch, these functions
only need the file*.  The inode can be gotten off of that.

Joel

-- 

"I have never let my schooling interfere with my education."
        - Mark Twain

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

      reply	other threads:[~2010-06-29 23:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29  8:27 [Ocfs2-devel] [PATCH 0/4] Add readahead support in CoW for reflinked files Tao Ma
2010-06-29  8:35 ` [Ocfs2-devel] [PATCH 1/4] ocfs2: Add struct file to ocfs2_refcount_cow Tao Ma
2010-06-29 23:14   ` Joel Becker
2010-06-30  1:34     ` Tao Ma
2010-06-30  3:11     ` Tao Ma
2010-06-30 12:00       ` Joel Becker
2010-07-01  0:17         ` Tao Ma
2010-07-01  9:12           ` Joel Becker
2010-07-01  9:20             ` Tao Ma
2010-06-29  8:35 ` [Ocfs2-devel] [PATCH 2/4] ocfs2: Add readahead support for CoW Tao Ma
2010-06-29  8:35 ` [Ocfs2-devel] [PATCH 3/4] ocfs2: Add readhead during CoW Tao Ma
2010-06-29 23:23   ` Joel Becker
2010-06-30  1:46     ` Tao Ma
2010-06-29  8:35 ` [Ocfs2-devel] [PATCH 4/4] ocfs2: make mmap CoW work with readahead Tao Ma
2010-06-29 23:24   ` Joel Becker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100629232423.GJ4150@mail.oracle.com \
    --to=joel.becker@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).